Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change BatchLogRecordProcessorFactory::Create to static method #1876

Merged
merged 2 commits into from
Dec 21, 2022
Merged

Change BatchLogRecordProcessorFactory::Create to static method #1876

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0e9b4cd
Change BatchLogRecordProcessorFactory::Create to static method, Fixed…
ninghejun Dec 20, 2022
da3957d
Merge branch 'main' into log_factory_dev
lalitb Dec 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ Increment the:

## [Unreleased]

* [METRICS] Change BatchLogRecordProcessorFactory::Create to static method
* [BUILD] Fix OTELCPP_MAINTAINER_MODE [#1844](https://github.com/open-telemetry/opentelemetry-cpp/pull/1844)
* [BUILD] Fix compatibility when using clang and libc++, upgrade GTest and
cmake when using C++20 [#1852](https://github.com/open-telemetry/opentelemetry-cpp/pull/1852)
Expand Down
2 changes: 1 addition & 1 deletion sdk/include/opentelemetry/sdk/common/global_log_handler.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ class GlobalLogHandler
OPENTELEMETRY_END_NAMESPACE

/**
* GlobalLogHandler and TracerProvider/MeterProvider/LoggerProvider are lazy sigletons.
* GlobalLogHandler and TracerProvider/MeterProvider/LoggerProvider are lazy singletons.
* To ensure that GlobalLogHandler is the first one to be initialized (and so last to be
* destroyed), it is first used inside the constructors of TraceProvider, MeterProvider
* and LoggerProvider for debug logging. */
Expand Down
4 changes: 2 additions & 2 deletions sdk/include/opentelemetry/sdk/logs/batch_log_record_processor_factory.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,8 @@ class BatchLogRecordProcessorFactory
/**
* Create a BatchLogRecordProcessor.
*/
std::unique_ptr<LogRecordProcessor> Create(std::unique_ptr<LogRecordExporter> &&exporter,
const BatchLogRecordProcessorOptions &options);
static std::unique_ptr<LogRecordProcessor> Create(std::unique_ptr<LogRecordExporter> &&exporter,
const BatchLogRecordProcessorOptions &options);
};

} // namespace logs
Expand Down