Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change BatchLogRecordProcessorFactory::Create to static method #1876

Merged
merged 2 commits into from
Dec 21, 2022

Conversation

ninghejun
Copy link
Contributor

Change BatchLogRecordProcessorFactory::Create to static method.
Fixed a typo in a comment.

Fixes # (issue)

Changes

  • [METRICS] Change BatchLogRecordProcessorFactory::Create to static method

Please provide a brief description of the changes here.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@ninghejun ninghejun requested a review from a team December 20, 2022 07:38
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Dec 20, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: ninghejun / name: andyning (0e9b4cd)

Copy link
Member

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the fix.

@codecov
Copy link

codecov bot commented Dec 20, 2022

Codecov Report

Merging #1876 (da3957d) into main (066c2f3) will decrease coverage by 0.08%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1876      +/-   ##
==========================================
- Coverage   85.79%   85.71%   -0.07%     
==========================================
  Files         171      171              
  Lines        5240     5240              
==========================================
- Hits         4495     4491       -4     
- Misses        745      749       +4     
Impacted Files Coverage Δ
...lude/opentelemetry/sdk/common/global_log_handler.h 72.23% <ø> (ø)
ext/src/http/client/curl/http_client_curl.cc 80.31% <0.00%> (-1.13%) ⬇️
sdk/src/trace/batch_span_processor.cc 90.63% <0.00%> (-0.78%) ⬇️

@lalitb lalitb merged commit 9dd19a2 into open-telemetry:main Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants