Fix compatibility when using clang and libc++ #1852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1852 +/- ##
==========================================
- Coverage 85.79% 85.77% -0.01%
==========================================
Files 171 171
Lines 5240 5240
==========================================
- Hits 4495 4494 -1
- Misses 745 746 +1
|
owent
force-pushed
the
fix_1851
branch
2 times, most recently
from
c656ae4 to
9381bb7
Compare
marcalff
reviewed
Dec 8, 2022
owent
changed the title
owent
changed the title
lalitb
approved these changes
Dec 9, 2022
ThomsonTan
reviewed
Dec 9, 2022
ThomsonTan
reviewed
Dec 9, 2022
| # include <type_traits> | ||
|
|
||
| /** | ||
| * @brief Clang 14.0.0 with libc++ do not support implicitly construct a span for a range.We just |
There was a problem hiding this comment.
Suggested change
| * @brief Clang 14.0.0 with libc++ do not support implicitly construct a span for a range.We just | |
| * @brief Clang 14.0.0 with libc++ do not support implicitly construct a span for a range. We just |
Is this an issue for clang with libc++ 14.0.0?
There was a problem hiding this comment.
Yes, In my tests, clang with libc++ 14.0.1 do not has this problem, but if we install clang-14 through apt install clang-14 libc++-dev-14 libc++1-14 libc++abi-dev-14 libc++abi1-14 on Ubuntu 22.04, it will install 14.0.0 now(I run apt update on 2022-12-09).
ThomsonTan
reviewed
Dec 9, 2022
| @@ -89,11 +89,13 @@ struct Uri | |||
| class NoopEventHandler : public http_client::EventHandler | |||
| { | |||
| public: | |||
| void OnEvent(http_client::SessionState state, nostd::string_view reason) noexcept override {} | |||
| void OnEvent(http_client::SessionState /* state */, | |||
There was a problem hiding this comment.
Is this introduced to workaround some compilation warning? Wrap the parameter name in inline comment seems more verbose than the original parameter there.
There was a problem hiding this comment.
Yes, clang will trigger -Werror,-Wunused-parameter when compiling with -Wextra -Werror.
marcalff
approved these changes
Dec 12, 2022
lalitb
reviewed
Dec 12, 2022
Signed-off-by: owent <[email protected]> Merge partly of open-telemetry#1844 Signed-off-by: owent <[email protected]> Update gtest to 1.12.1 by default Signed-off-by: owent <[email protected]> Fix compatibility when using clang and libc++ Signed-off-by: owent <[email protected]> No need build local gtest when using legacy toolchain. Signed-off-by: owent <[email protected]> Fix env in sudo Signed-off-by: owent <[email protected]> Add hint to print current C++ standard and stdlib for cmake. Signed-off-by: owent <[email protected]> Print output of C++ environment detection Signed-off-by: owent <[email protected]> Allow to set cxx flags by environments in CI jobs. Signed-off-by: owent <[email protected]> fix MAINTAINER_MODE: - bump gcc to version 12 - bump clang to version 14 - expand coverage on W3C tests Upgrade gootletest 1.12.1 Fixed new warnings. Fixed format, added changelog. Using fallback version of span when `std::span` do not support `range`. Signed-off-by: owent <[email protected]>
Signed-off-by: owent <[email protected]>
Signed-off-by: owent <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: owent [email protected]
Fixes #1851
Changes
std::spando not supportrange.cmake.c++20.testandcmake.c++20.stl.test.(3.20.0is the first version that support to add-std=c++20to both gcc and clang.)ATOMIC_FLAG_INITusage when has__cpp_lib_atomic_value_initialization. (C++20)-Werrorand it will cause compiling error on modern compilers.)-stdlib=libc++.For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes