Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI benchmark doesn't build on Ubuntu 22.04 #1801

Closed
ThomsonTan opened this issue Nov 23, 2022 · 1 comment
Closed

CI benchmark doesn't build on Ubuntu 22.04 #1801

ThomsonTan opened this issue Nov 23, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@ThomsonTan
Copy link
Contributor

While it was reverted back to Ubuntu 20.04 to unblock CI benchmark in below CI, we need investigate why it doesn't work with Ubuntu 22.04 because we'll move there in the long term.

#1799

@ThomsonTan ThomsonTan added the bug Something isn't working label Nov 23, 2022
@marcalff
Copy link
Member

Ubuntu 20.04 with an old gcc worked with gtest 1.10.0

Ubuntu 22.02 with a newer gcc broke with gtest 1.10.0

With recent changes : issue #1852, the version of gtest was bumped up:
export GOOGLETEST_VERSION=1.12.1

Ubuntu 22.02 with a newer gcc works with gtest 1.12.1

So, #1852 as a side effect also fixed the benchmarks workflow.

Closing, as this is now resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants