Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Deprecation] Deprecate experimental semantic conventions (#1742) #1744

Merged

Conversation

marcalff
Copy link
Member

@marcalff marcalff commented Nov 7, 2022

Fixes #1742

Changes

Announce the deprecation of experimental semantic conventions in the CHANGELOG.

Announce the deprecation of a global hash function.

This function is not declared in the opentelemetry namespace, and as such, is considered potentially harmful to the application code.

This function is not part of the opentelemetry-cpp API, but rather an implementation artifact of experimental semantic conventions that leaked and got exposed to the application code.

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@marcalff marcalff requested a review from a team November 7, 2022 22:37
@codecov
Copy link

codecov bot commented Nov 7, 2022

Codecov Report

Merging #1744 (c3bf495) into main (a220ac4) will decrease coverage by 0.02%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1744      +/-   ##
==========================================
- Coverage   85.79%   85.77%   -0.01%     
==========================================
  Files         171      171              
  Lines        5212     5212              
==========================================
- Hits         4471     4470       -1     
- Misses        741      742       +1     
Impacted Files Coverage Δ
sdk/src/trace/batch_span_processor.cc 90.63% <0.00%> (-0.78%) ⬇️

@ThomsonTan ThomsonTan merged commit 702a68c into open-telemetry:main Nov 9, 2022
@marcalff marcalff deleted the deprecate_experimental_semconv_1742 branch July 4, 2023 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Deprecation] Deprecate experimental semantic conventions.
3 participants