-
Notifications
You must be signed in to change notification settings - Fork 438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Removal] Remove deprecated experimental semantic conventions (#1741) #1743
Merged
lalitb
merged 5 commits into
open-telemetry:main
from
marcalff:remove_experimental_semconv_1741
Dec 8, 2022
Merged
[Removal] Remove deprecated experimental semantic conventions (#1741) #1743
lalitb
merged 5 commits into
open-telemetry:main
from
marcalff:remove_experimental_semconv_1741
Dec 8, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1743 +/- ##
==========================================
- Coverage 85.79% 85.73% -0.05%
==========================================
Files 171 171
Lines 5240 5240
==========================================
- Hits 4495 4492 -3
- Misses 745 748 +3
|
marcalff
changed the title
[DO NOT MERGE] [Removal] Remove deprecated experimental semantic conventions (#1741)
[Removal] Remove deprecated experimental semantic conventions (#1741)
Nov 28, 2022
marcalff
added
issue:blocked
Fix blocked, waiting for other fixes as prerequisites
pr:do-not-merge
This PR is not ready to be merged.
and removed
pr:do-not-merge
This PR is not ready to be merged.
issue:blocked
Fix blocked, waiting for other fixes as prerequisites
labels
Nov 28, 2022
lalitb
approved these changes
Dec 5, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
esigo
approved these changes
Dec 5, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for the PR :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1741
Changes
Remove deprecated files:
Remove deprecated global function:
CHANGELOG.md
updated for non-trivial changes