Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Metrics SDK] Add Metrics ExemplarFilter and ExemplarReservoir #1584
[Metrics SDK] Add Metrics ExemplarFilter and ExemplarReservoir #1584
Changes from 11 commits
20199aa
8b0802d
b7c9a15
2270ba7
f00fedc
a28f6e0
bfdeebd
7675492
d1f3523
43ea414
b268da3
566d3fd
5bbc658
0ac42d4
339bef5
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as per the specs, there are only two reservoirs -SimpleFixedSizeExemplarReservoir, AlignedHistogramBucketExemplarReservoir. What is the purpose of this reservoir.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a reservoir that has a pre-filter on measurements. Java has it. Shall I remove it?
I think a filter per trace would be interesting for the users.