[Metrics SDK] Add Metrics ExemplarFilter and ExemplarReservoir #1584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
esigo
changed the title
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1584 +/- ##
==========================================
- Coverage 85.04% 84.33% -0.70%
==========================================
Files 159 168 +9
Lines 4990 5122 +132
==========================================
+ Hits 4243 4319 +76
- Misses 747 803 +56
|
esigo
changed the title
lalitb
reviewed
Sep 20, 2022
sdk/include/opentelemetry/sdk/metrics/exemplar/with_trace_sample_filter.h
Outdated
Show resolved
Hide resolved
| { | ||
| namespace metrics | ||
| { | ||
| class FilteredExemplarReservoir final : public ExemplarReservoir |
There was a problem hiding this comment.
as per the specs, there are only two reservoirs -SimpleFixedSizeExemplarReservoir, AlignedHistogramBucketExemplarReservoir. What is the purpose of this reservoir.
There was a problem hiding this comment.
This is a reservoir that has a pre-filter on measurements. Java has it. Shall I remove it?
I think a filter per trace would be interesting for the users.
lalitb
reviewed
Sep 28, 2022
sdk/include/opentelemetry/sdk/metrics/exemplar/reservoir_cell_selector.h
Show resolved
Hide resolved
sdk/include/opentelemetry/sdk/metrics/exemplar/fixed_size_exemplar_reservoir.h
Outdated
Show resolved
Hide resolved
sdk/include/opentelemetry/sdk/metrics/exemplar/histogram_exemplar_reservoir.h
Show resolved
Hide resolved
sdk/include/opentelemetry/sdk/metrics/exemplar/histogram_exemplar_reservoir.h
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1498 (issue)
Changes
implements
FilteredExemplarReservoir,HistogramExemplarReservoirandWithTraceSampleFilter.For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes