-
Notifications
You must be signed in to change notification settings - Fork 438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Metrics] Add OTLP http metric exporter #1487
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1487 +/- ##
==========================================
- Coverage 84.72% 84.66% -0.06%
==========================================
Files 156 156
Lines 4784 4784
==========================================
- Hits 4053 4050 -3
- Misses 731 734 +3
|
26a6826
to
456bd6c
Compare
@lalitb Could you please review this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Nicely done. There are a few improvements I can see to be done for the OTLP GRPC Metrics exporter. I will raise a PR for that.
@owent - Have some conflicts to resolve here :) |
0acfe4d
to
7ef9684
Compare
Resloved |
@owent - Can you please rebase it, so can be merged. |
Signed-off-by: owentou <[email protected]>
Signed-off-by: owentou <[email protected]>
Signed-off-by: owentou <[email protected]>
…cUtils::PopulateRequest` Signed-off-by: owentou <[email protected]>
Signed-off-by: owentou <[email protected]>
Signed-off-by: owentou <[email protected]>
Signed-off-by: owentou <[email protected]>
7ef9684
to
4fe3069
Compare
Done |
* Add OTLP http metric exporter Signed-off-by: owentou <[email protected]> * Add changelog for OTLP HTTP metric exporter Signed-off-by: owentou <[email protected]> * Add unit test of `SumPointData` for `OtlpHttpMetricExporter` Signed-off-by: owentou <[email protected]> * Fix dependency of otlp recordable, add `Gauge` support for `OtlpMetricUtils::PopulateRequest` Signed-off-by: owentou <[email protected]> * Add unit test for `OtlpHttpMetricExporter` Signed-off-by: owentou <[email protected]> * Fix format Signed-off-by: owentou <[email protected]> * Fix unit test `OtlpMetricSerializationTest.ObservableGauge` Signed-off-by: owentou <[email protected]>
* Add OTLP http metric exporter Signed-off-by: owentou <[email protected]> * Add changelog for OTLP HTTP metric exporter Signed-off-by: owentou <[email protected]> * Add unit test of `SumPointData` for `OtlpHttpMetricExporter` Signed-off-by: owentou <[email protected]> * Fix dependency of otlp recordable, add `Gauge` support for `OtlpMetricUtils::PopulateRequest` Signed-off-by: owentou <[email protected]> * Add unit test for `OtlpHttpMetricExporter` Signed-off-by: owentou <[email protected]> * Fix format Signed-off-by: owentou <[email protected]> * Fix unit test `OtlpMetricSerializationTest.ObservableGauge` Signed-off-by: owentou <[email protected]>
Fixes #1371
Changes
Shutdown
test for all OTLP HTTP exportersForceFlush
forOtlpHttpClient
Gauge
support forOtlpMetricUtils::PopulateRequest
For significant contributions please make sure you have completed the following items:
CHANGELOG.md
updated for non-trivial changes