Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Metrics] Otlp metric gRPC exporter has a wrong name. #1484

Closed
owent opened this issue Jul 11, 2022 · 3 comments · Fixed by #1488
Closed

[Metrics] Otlp metric gRPC exporter has a wrong name. #1484

owent opened this issue Jul 11, 2022 · 3 comments · Fixed by #1488
Assignees
@lalitb
Labels
bug Something isn't working

Comments

@owent
Copy link
Member

owent commented Jul 11, 2022

Should OtlpGrpcMetrics* be OtlpGrpcMetric* ? I found the name with (s) are used for legacy _metrics implements in other exporters, but OtlpGrpcMetricsExporter is implement of new metric SDK?
@lalitb
@owent owent added the bug Something isn't working label Jul 11, 2022
@lalitb
Copy link
Member

lalitb commented Jul 11, 2022 •
edited
Loading

@owent - Correct, It should be OtlpGrpcMetricExporter for new implementation. Would then be consistent with OStreamMetricExporter and InMemoryMetricExporter (from #1481). Please feel free to assign it to me. Thanks :)

@owent
Copy link
Member Author

owent commented Jul 11, 2022

And bazel script is missing for OtlpGrpcMetricExporter now.

@lalitb lalitb mentioned this issue Jul 11, 2022
Merged
3 tasks
@lalitb
Copy link
Member

lalitb commented Jul 12, 2022

And bazel script is missing for OtlpGrpcMetricExporter now.

Will fix this one #1481 and #1487 are merged to avoid any further merge conflicts :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lalitb lalitb

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #1484 (Rename OTLP gRPC metric exporter) lalitb/opentelemetry-cpp
2 participants
@lalitb @owent