-
Notifications
You must be signed in to change notification settings - Fork 438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Aggregation Storage #1213
Merged
Merged
Add Aggregation Storage #1213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1213 +/- ##
==========================================
- Coverage 93.35% 92.99% -0.36%
==========================================
Files 193 196 +3
Lines 6908 7038 +130
==========================================
+ Hits 6448 6544 +96
- Misses 460 494 +34
|
esigo
reviewed
Feb 15, 2022
esigo
reviewed
Feb 15, 2022
sdk/include/opentelemetry/sdk/metrics/state/attributes_hashmap.h
Outdated
Show resolved
Hide resolved
esigo
reviewed
Feb 15, 2022
esigo
reviewed
Feb 15, 2022
esigo
reviewed
Feb 15, 2022
sdk/include/opentelemetry/sdk/metrics/state/sync_metric_storage.h
Outdated
Show resolved
Hide resolved
esigo
reviewed
Feb 15, 2022
sdk/include/opentelemetry/sdk/metrics/state/sync_metric_storage.h
Outdated
Show resolved
Hide resolved
esigo
approved these changes
Feb 16, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for the PR :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1197 #1202
Changes
As discussed in today's community meeting, this PR adds the first part of Aggregation Storage - to consume/record the measurements and store them against the Aggregation objects. To achieve thread-safe aggregation storage, we use a non-blocking mutex lock SpinLockMutex. The benchmark tests are added, and will continue to look into lock-free concurrent storage libraries in C++ ( similar to [ConcurrentHashMap ](https://docs.oracle.com/javase/8/docs/api/java/util/concurrent/ConcurrentHashMap.html in java ) which provides lock free retrievals. Some of the available options to look into:
For significant contributions please make sure you have completed the following items:
CHANGELOG.md
updated for non-trivial changes