-
Notifications
You must be signed in to change notification settings - Fork 438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jaeger: ThriftSender unit test #1162
Merged
ThomsonTan
merged 8 commits into
open-telemetry:main
from
esigo:Jaeger-ThriftSender-unit-test
Jan 3, 2022
Merged
Jaeger: ThriftSender unit test #1162
ThomsonTan
merged 8 commits into
open-telemetry:main
from
esigo:Jaeger-ThriftSender-unit-test
Jan 3, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1162 +/- ##
==========================================
+ Coverage 93.25% 93.26% +0.02%
==========================================
Files 173 173
Lines 6362 6362
==========================================
+ Hits 5932 5933 +1
+ Misses 430 429 -1
|
esigo
changed the title
[WIP] Jaeger: ThriftSender unit test
Jaeger: ThriftSender unit test
Dec 22, 2021
lalitb
approved these changes
Dec 27, 2021
bjosv
approved these changes
Jan 3, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Sorry for late response.
ThomsonTan
approved these changes
Jan 3, 2022
This was referenced Jan 25, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds unit test to cover the memory leak issue reported in #1160
Changes
Mocks
Transport
so that we can reachThriftSender::Append
whenJaegerExporter::Export
was called.For significant contributions please make sure you have completed the following items:
CHANGELOG.md
updated for non-trivial changes