Fix leak in Jaeger exporter #1160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lalitb
approved these changes
Dec 22, 2021
Codecov Report
@@ Coverage Diff @@
## main #1160 +/- ##
=======================================
Coverage 93.38% 93.38%
=======================================
Files 165 165
Lines 6233 6233
=======================================
Hits 5820 5820
Misses 413 413 |
esigo
approved these changes
Dec 22, 2021
Great! Was thinking of looking into this, but just let me know If I can be of any help. |
|
We can catch the leak in the new test. |
|
@bjosv - can you update the branch to main, to allow this to be merged. |
The jaeger_span was never destroyed after its release from the JaegerRecordable. This change let a `std::unique_ptr` handle the destruction when going out of scope, first allowing the `thrift::Span` to be copied to the `span_buffer_`.
bjosv
force-pushed
the
fix-leak-jaeger-exporter
branch
from
902fdfe to
be83b1d
Compare
|
@lalitb The PR has now been updated to the latest from main. |
|
CI step It doesn't seem to be related to my correction according to the output, but I'm not familiar with the test. |
|
Thanks for catching and fixing. |
This was referenced Jan 25, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During our introduction of Jaeger and using the
JaegerExporterwe found this memory leak.There is currently no unittest for the
JaegerExporterin opentelemetry-cpp that could have caught this, but maybe we should add something similar to the ongoingZipkinExportertest (#1155)?Changes
The jaeger_span was never destroyed after its release from the JaegerRecordable.
This change let a
std::unique_ptrhandle the destruction when going out of scope, first allowing thethrift::Spanto be copied to thespan_buffer_.For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes