Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUILD] Build warnings reported by clang. #1649

Closed
marcalff opened this issue Oct 3, 2022 · 1 comment · Fixed by #1658
Closed

[BUILD] Build warnings reported by clang. #1649

marcalff opened this issue Oct 3, 2022 · 1 comment · Fixed by #1658
Assignees
@marcalff
Labels
bug Something isn't working

Comments

@marcalff
Copy link
Member

marcalff commented Oct 3, 2022

The code still contains build warnings.

Found more when compiling with clang, and using WITH_STL.

In the long term, we need to have a CI build to check warnings, see issue #1648 .
@marcalff marcalff added the bug Something isn't working label Oct 3, 2022
@marcalff marcalff self-assigned this Oct 3, 2022
@lalitb
Copy link
Member

lalitb commented Oct 3, 2022

related issue for gcc, clang and msvc #249

@marcalff marcalff mentioned this issue Oct 3, 2022
Merged
3 tasks
marcalff added a commit to marcalff/opentelemetry-cpp that referenced this issue Oct 5, 2022
@marcalff
Fix open-telemetry#1649
bbe8a6c 
Fixed some warnings reported by clang.

-Wnewline-eof
  no newline at end of file

-Wc++98-compat-extra-semi
  extra ';' outside of a function is incompatible with C++98

-Winconsistent-missing-destructor-override
  '~XXX' overrides a destructor but is not marked 'override'

-Wheader-hygiene
  using namespace directive in global context in header

-Wunused-parameter
  unused parameter

Fixed some warnings reported by gcc.

-Werror=missing-field-initializers
  missing initializer for member ‘opentelemetry::v1::sdk::trace::SamplingResult::trace_state’

-Werror=unused-variable
  unused variable

-Werror=unused-parameter
  unused parameter
@marcalff marcalff mentioned this issue Oct 5, 2022
Merged
3 tasks
lalitb pushed a commit that referenced this issue Oct 5, 2022
@marcalff
Fix #1649 (#1658)
1dc810d 
Fixed some warnings reported by clang.

-Wnewline-eof
  no newline at end of file

-Wc++98-compat-extra-semi
  extra ';' outside of a function is incompatible with C++98

-Winconsistent-missing-destructor-override
  '~XXX' overrides a destructor but is not marked 'override'

-Wheader-hygiene
  using namespace directive in global context in header

-Wunused-parameter
  unused parameter

Fixed some warnings reported by gcc.

-Werror=missing-field-initializers
  missing initializer for member ‘opentelemetry::v1::sdk::trace::SamplingResult::trace_state’

-Werror=unused-variable
  unused variable

-Werror=unused-parameter
  unused parameter
yxue pushed a commit to yxue/opentelemetry-cpp that referenced this issue Dec 5, 2022
@marcalff @yxue
Fix open-telemetry#1649 (open-telemetry#1658)
841870c 
Fixed some warnings reported by clang.

-Wnewline-eof
  no newline at end of file

-Wc++98-compat-extra-semi
  extra ';' outside of a function is incompatible with C++98

-Winconsistent-missing-destructor-override
  '~XXX' overrides a destructor but is not marked 'override'

-Wheader-hygiene
  using namespace directive in global context in header

-Wunused-parameter
  unused parameter

Fixed some warnings reported by gcc.

-Werror=missing-field-initializers
  missing initializer for member ‘opentelemetry::v1::sdk::trace::SamplingResult::trace_state’

-Werror=unused-variable
  unused variable

-Werror=unused-parameter
  unused parameter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marcalff marcalff

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix more clang and gcc warnings marcalff/opentelemetry-cpp
2 participants
@lalitb @marcalff