Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Add a -Wall -Werror build #1648

Closed
marcalff opened this issue Oct 3, 2022 · 2 comments · Fixed by #1650
Closed

[CI] Add a -Wall -Werror build #1648

marcalff opened this issue Oct 3, 2022 · 2 comments · Fixed by #1650
Assignees
Labels
bug Something isn't working build and test

Comments

@marcalff
Copy link
Member

marcalff commented Oct 3, 2022

Add a build in CI to detect compilation warnings, and fail the build on warnings.

To test with a recent version of GCC and/or CLANG.

The build in general should be clean.

In particular, user visible headers (like the API) should be warning free,
to allow the user code to build warning free.

Adding a CI build to enforce this will help to maintain clean code.

@marcalff marcalff added the bug Something isn't working label Oct 3, 2022
@marcalff marcalff self-assigned this Oct 3, 2022
@sirzooro
Copy link

sirzooro commented Oct 3, 2022

Please build using both gcc and clang if possible. Both compilers have different diagnostics, so some issues are detected by one of them only.

marcalff added a commit to marcalff/opentelemetry-cpp that referenced this issue Oct 3, 2022
Add a MAINTAINER_MODE in CMake.

Build with gcc and clang in maintainer mode in github CI.
@marcalff
Copy link
Member Author

marcalff commented Oct 3, 2022

Please build using both gcc and clang if possible. Both compilers have different diagnostics, so some issues are detected by one of them only.

Yes, planning both.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working build and test
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants