Add schema for ProbabilitySampler#339
Conversation
| } | ||
| } | ||
| }, | ||
| "ProbabilitySampler": { |
There was a problem hiding this comment.
| "ProbabilitySampler": { | |
| "ExperimentalProbabilitySampler": { |
We denote experimental types with Experimental prefix
jack-berg
left a comment
jack-berg
left a comment
There was a problem hiding this comment.
Its good to have an example in kitchen-sink.yaml even for experimental types. Samplers are a bit of an edge case right now because you can only assign one to .tracer_provider.
Also, we're trying to keep type_descriptions.yaml up to date with descriptions describing the semantics / defaults of all properties. Currently, those descriptions manifest as comments automatically added to the example files, but with no surface in the examples, it seems kind of silly.
I'm proposing a better way to maintaining extra schema meta data in #312, which amongst other things adds build tooling guaranteeing that every property for every type has a description.
| "parent_based": { | ||
| "$ref": "#/$defs/ParentBasedSampler" | ||
| }, | ||
| "probability": { |
There was a problem hiding this comment.
| "probability": { | |
| "probability/development": { |
|
Thanks @jack-berg - sorry for missing the note on experimental types, fixed and also updated the schemas / kitchen sink |
| # If omitted or null, always_off is used. | ||
| remote_parent_not_sampled: | ||
| # Configure sampler to be always_off. | ||
| always_off: |
There was a problem hiding this comment.
Repurposed this one since always_off is already present below
anuraaga
force-pushed
the
probability-def
branch
from
8cd3625 to
0809b78
Compare
2 participants
Fixes #315
The user interface for
ProbabilitySampleris identical to the legacyTraceIdRatioBasedSamplerso the schema is the same.I didn't update any examples because the sampler is still Development level and isn't provided in most SDKs yet.