Introduce proper meta schema concept#312
Conversation
|
LGTM, but I did not review scripts/*, since I don't speak |
|
@open-telemetry/configuration-approvers anybody interested in discussed / reviewing this? Its a decent amount of code, but the stakes are low because its "build" code, as opposed to part of the schema, examples, stability guarantees. My view is we should land this and iterate. |
On this:
Yes, I agree we should merge it. I reviewed the schema/instrumentation.json part because it affects the schema, and it looks ok. As for the js code, as noted earlier, I can't review it. Now:
Pushing the approve button to unblock this, there is no point in letting this work rot, it will serve all of us better in the main branch. Please rebase, re generate the doc, and ok to merge. |
|
This is for later so not part of this review. Out of curiosity, I looked at the SDK implementation status, and found out that java supports the What is the meaning of
To clarify once #312 is merged, with the next PR to represent per language support: we may need more statuses, like |
Yup we got to work out what kind of information we want to capture in support status, and how to represent it so its efficient for maintainers to record / update. I sketched out something quick but imagined we'd probably need an enumeration of possible support statuses, along with the ability to elaborate with an optional description. Let's chat in the followup PR! |
216b70e to
5c9dfec
Compare
5c9dfec to
3c94dcb
Compare
Meta schema is the evolution of
type_descriptions.yaml, and holds all types of details that don't fit neatly into the JSON schema.Initial use cases include:
type_descriptions.yaml, we should evolve this to more precisely model the semantics. I.e. break out high level description, SDK interpretation, default behavior.I wrote a useful summary of the meta schema and associated tasks here: https://github.com/jack-berg/opentelemetry-configuration/blob/meta-schema/CONTRIBUTING.md#meta-schema
Please read while reviewing!