Skip to content

Clarify ToVersion as removal version for stable feature gates #15039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
johnmichaelll238-cloud wants to merge 2 commits into from
Closed

Clarify ToVersion as removal version for stable feature gates #15039

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d73a667
Clarify ToVersion as removal version for stable feature gates
johnmichaelll238-cloud Mar 31, 2026
f5dc621
Validate ToVersion for stable or deprecated stages
johnmichaelll238-cloud Apr 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion featuregate/gate.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,8 @@ func (g *Gate) FromVersion() string {
return fmt.Sprintf("v%s", g.fromVersion)
}

// ToVersion returns the version information when Gate's in StageStable.
// ToVersion specifies the version in which a feature gate in StageStable
Comment thread
johnmichaelll238-cloud marked this conversation as resolved.
// is scheduled to be removed. This is only applicable for features in StageStable and should be set to nil for features in other stages.
Comment thread
johnmichaelll238-cloud marked this conversation as resolved.
func (g *Gate) ToVersion() string {
return fmt.Sprintf("v%s", g.toVersion)
}
7 changes: 6 additions & 1 deletion featuregate/registry.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,12 @@ func (r *Registry) Register(id string, stage Stage, opts ...RegisterOption) (*Ga
return nil, fmt.Errorf("failed to apply option: %w", err)
}
}
switch g.stage {
if g.ToVersion != nil {
Comment thread
johnmichaelll238-cloud marked this conversation as resolved.
if g.Stage != StageStable && !g.Stage.IsDeprecated(){
return fmt.Errorf("ToVersion can only be set for stable or deprecated stages")
}
}
switch g.stage {
case StageAlpha, StageDeprecated:
g.enabled = &atomic.Bool{}
case StageBeta, StageStable:
Expand Down