Clarify ToVersion as removal version for stable feature gates#15039
Closed
johnmichaelll238-cloud wants to merge 2 commits intoopen-telemetry:mainfrom
Closed
Clarify ToVersion as removal version for stable feature gates#15039johnmichaelll238-cloud wants to merge 2 commits intoopen-telemetry:mainfrom
johnmichaelll238-cloud wants to merge 2 commits intoopen-telemetry:mainfrom
Conversation
Member
|
Please sign the CLA. |
Author
OK. I did so just now. Thank you. |
dmathieu
reviewed
Mar 31, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #15039 +/- ##
=======================================
Coverage 91.22% 91.22%
=======================================
Files 697 697
Lines 44627 44627
=======================================
Hits 40710 40710
Misses 2773 2773
Partials 1144 1144 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Add validation for ToVersion in feature gate stages
dmathieu
reviewed
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11341
This PR clarifies the meaning of the
ToVersionfield in the godoc comments ofGatein the featuregate package.Currently, the godoc was vague, saying it “returns version information when StageStable,” which caused confusion. In practice,
ToVersionrepresents the version in which a feature gate in StageStable is scheduled to be removed. This update makes the intended behaviour explicit and aligns the documentation with the actual code behaviour.No code changes were made—only documentation is updated.