[chore] Add missing chloggen component types#14626
Conversation
Assisted-by: Claude Opus 4.6
| } | ||
| } | ||
|
|
||
| func TestValidateMetricDuplicates(t *testing.T) { |
There was a problem hiding this comment.
This test is a holdover from when mdatagen was hosted in contrib. The Git blame on this shows it hasn't been touched since it was copied to core.
The test doesn't make any sense for this repo (the callout components in allowedMetrics are contrib components), so I think we're better off just removing it.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #14626 +/- ##
==========================================
- Coverage 91.83% 91.82% -0.01%
==========================================
Files 679 679
Lines 42921 42921
==========================================
- Hits 39415 39411 -4
- Misses 2438 2440 +2
- Partials 1068 1070 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Build passes, I think this is ready to merge. |
Merging this PR will improve performance by 27.66%
|
| Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|
| ⚡ | BenchmarkMetricsToProto2k |
91.4 µs | 73.1 µs | +25.11% |
| ⚡ | BenchmarkTraceSizeSpanCount |
60 ns | 47 ns | +27.66% |
Comparing evan-bradley:add-chloggen-components (464b6f1) with main (6dd7ac8)
Footnotes
-
20 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
1b90e21
Description
A lot of our modules are missing
metadata.yamlfiles, which are used by githubgen to determine which modules are available to be put in the list of components eligible for a changelog entry.There were also two
extension/xextensionentries that were in my opinion misclassified packages, so I fixed those as well.