Skip to content

[chore] Add missing chloggen component types#14626

Merged
mx-psi merged 2 commits into
open-telemetry:mainfrom
evan-bradley:add-chloggen-components
Feb 24, 2026
Merged

[chore] Add missing chloggen component types#14626
mx-psi merged 2 commits into
open-telemetry:mainfrom
evan-bradley:add-chloggen-components

Conversation

@evan-bradley
Copy link
Copy Markdown
Contributor

Description

A lot of our modules are missing metadata.yaml files, which are used by githubgen to determine which modules are available to be put in the list of components eligible for a changelog entry.

There were also two extension/xextension entries that were in my opinion misclassified packages, so I fixed those as well.

Assisted-by: Claude Opus 4.6
@evan-bradley evan-bradley requested review from a team and mx-psi as code owners February 23, 2026 22:18
}
}

func TestValidateMetricDuplicates(t *testing.T) {
Copy link
Copy Markdown
Contributor Author

@evan-bradley evan-bradley Feb 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test is a holdover from when mdatagen was hosted in contrib. The Git blame on this shows it hasn't been touched since it was copied to core.

The test doesn't make any sense for this repo (the callout components in allowedMetrics are contrib components), so I think we're better off just removing it.

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 24, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.82%. Comparing base (95aacc1) to head (464b6f1).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14626      +/-   ##
==========================================
- Coverage   91.83%   91.82%   -0.01%     
==========================================
  Files         679      679              
  Lines       42921    42921              
==========================================
- Hits        39415    39411       -4     
- Misses       2438     2440       +2     
- Partials     1068     1070       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@evan-bradley evan-bradley changed the title [chore] Add missing chloggen entries [chore] Add missing chloggen component types Feb 24, 2026
@evan-bradley evan-bradley added the ready-to-merge Code review completed; ready to merge by maintainers label Feb 24, 2026
@evan-bradley
Copy link
Copy Markdown
Contributor Author

Build passes, I think this is ready to merge.

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Feb 24, 2026

Merging this PR will improve performance by 27.66%

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚡ 2 improved benchmarks
✅ 59 untouched benchmarks
⏩ 20 skipped benchmarks1

Performance Changes

Benchmark BASE HEAD Efficiency
BenchmarkMetricsToProto2k 91.4 µs 73.1 µs +25.11%
BenchmarkTraceSizeSpanCount 60 ns 47 ns +27.66%

Comparing evan-bradley:add-chloggen-components (464b6f1) with main (6dd7ac8)

Open in CodSpeed

Footnotes

  1. 20 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@mx-psi mx-psi enabled auto-merge February 24, 2026 15:15
@mx-psi mx-psi added this pull request to the merge queue Feb 24, 2026
Merged via the queue into open-telemetry:main with commit 1b90e21 Feb 24, 2026
90 of 91 checks passed
@evan-bradley evan-bradley deleted the add-chloggen-components branch February 24, 2026 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge Code review completed; ready to merge by maintainers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants