Add context.Context to gRPC middleware interface constructors#14536
Conversation
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (90.90%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #14536 +/- ##
==========================================
- Coverage 91.83% 91.82% -0.02%
==========================================
Files 680 680
Lines 43009 43009
==========================================
- Hits 39497 39491 -6
- Misses 2443 2447 +4
- Partials 1069 1071 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Merging this PR will not alter performance
|
mx-psi
left a comment
There was a problem hiding this comment.
This seems fine to me, I think the breakage is both justified and within our guidelines
songy23
left a comment
There was a problem hiding this comment.
I suppose this needs a changelog?
…tor into jmacd/middleware_context2
…tor into jmacd/middleware_context2
evan-bradley
left a comment
There was a problem hiding this comment.
Thanks for patiently handling all of the administrative churn.
You'll need to merge in the changes from #14626, but otherwise looks good.
|
@jmacd please rebase |
…tor into jmacd/middleware_context2
|
@jmacd sorry for another ping, can you please fix the broken gates? |
…tor into jmacd/middleware_context2
f1a8858
#### Description API change in extensionmiddleware, an unstable package to allow middleware access to the start context. HTTP only. gRPC is treated in #14536. This is technically a breaking change in configmiddleware and for all implementations of this extension. We believe no one is using this feature outside of this repository, see memorylimiter is fixed here. #### Link to tracking issue Part of #14523 #### Documentation N/A
…elemetry#14536) #### Description API change in extensionmiddleware, an unstable package to allow middleware access to the start context. gRPC only. This exposes the same issue in HTTP middleware, which will have to be treated separately. This is technically a breaking change in configmiddleware and for all implementations of this extension. We believe no one is using this feature outside of this repository, see memorylimiter is fixed here. #### Link to tracking issue Fixes open-telemetry#14523 #### Documentation N/A
…elemetry#14549) #### Description API change in extensionmiddleware, an unstable package to allow middleware access to the start context. HTTP only. gRPC is treated in open-telemetry#14536. This is technically a breaking change in configmiddleware and for all implementations of this extension. We believe no one is using this feature outside of this repository, see memorylimiter is fixed here. #### Link to tracking issue Part of open-telemetry#14523 #### Documentation N/A
Description
API change in extensionmiddleware, an unstable package to allow middleware access to the start context.
gRPC only. This exposes the same issue in HTTP middleware, which will have to be treated separately.
This is technically a breaking change in configmiddleware and for all implementations of this extension. We believe no one is using this feature outside of this repository, see memorylimiter is fixed here.
Link to tracking issue
Fixes #14523
Documentation
N/A