[docs/rfc] Add component interface guidelines#14532
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #14532 +/- ##
=======================================
Coverage 90.34% 90.34%
=======================================
Files 699 699
Lines 53748 53748
=======================================
Hits 48559 48559
Misses 4044 4044
Partials 1145 1145 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…tor into jmacd/component_interface_v3
…elemetry-collector into jmacd/component_interface_v3
evan-bradley
left a comment
There was a problem hiding this comment.
Thanks for writing this, I wish I had this document when starting to work on the repo.
|
Amended the title just to make it a bit clearer this is an RFC. Also @jmacd could you add a short blurb linking to this document in CONTRIBUTING.md? I think it's a great contributor resource. |
|
@jmacd Can you make sure you have followed the 'announcement' requirements for RFCs? |
…tor into jmacd/component_interface_v3
|
As per #14532 (comment) we should hold off I will announce this as described. |
|
Fully announced, by now :-) |
|
@jmacd Can you fix the Markdown issues? If CI is fixed, I will merge this on Friday morning unless there are blocking comments by then |
…tor into jmacd/component_interface_v3
…elemetry-collector into jmacd/component_interface_v3
This comment was marked as low quality.
This comment was marked as low quality.
|
@jmacd I am ready to merge this whenever you fix the |
Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
Description
Specifies the mechanics of our approach to safe interface evolution.
See #14523
See #14525
See #13902
Testing
This pattern was "tested" in #13241 as I prototyped a rate-limiter extension.
Documentation
✅