Limiter extension API interfaces and implementation helpers (**draft 6**)#13241
Closed
jmacd wants to merge 69 commits into
Closed
Limiter extension API interfaces and implementation helpers (**draft 6**)#13241jmacd wants to merge 69 commits into
jmacd wants to merge 69 commits into
Conversation
…tor into jmacd/limiter_v4
…tor into jmacd/limiter_v4
…tor into jmacd/limiter_v4
jmacd
requested review from
a team,
bogdandrutu,
codeboten,
dmathieu,
dmitryax and
mx-psi
as code owners
jmacd
changed the title
…tor into jmacd/limiter_v6
Contributor
Author
|
Closed in favor of #13265 |
pull Bot
pushed a commit
to Stars1233/opentelemetry-collector
that referenced
this pull request
Apr 22, 2026
#### Description Specifies the mechanics of our approach to safe interface evolution. See open-telemetry#14523 See open-telemetry#14525 See open-telemetry#13902 #### Testing This pattern was "tested" in open-telemetry#13241 as I prototyped a rate-limiter extension. #### Documentation ✅ --------- Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com> Co-authored-by: Alex Boten <223565+codeboten@users.noreply.github.com> Co-authored-by: Pablo Baeyens <pablo.baeyens@datadoghq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Improves on the previous drafts:
Removes the SaturationChecker interface with only
MustDeny(). This feature was a mistake, the concept of saturation is not required. Thememorylimiterextensionis modeled as a rate-limiter extension, instead. This reduces API surface area significantly.Adds
consumerlimiterpackage withNewLimitedFactory()for constructing receivers with pipelines that automatically apply limiters, configured by embedding theconsumerlimiter.LimiterConfig, see the README.Documents a proposed collector extension interface style called "Functional Composition". This is a draft, see
docs/rfcs/functional-composition-pattern.md. If we like this, I'll put it in a separate PR.Middleware config syntax proposal. A number of people have stumbled over the current syntax, which has the
configmiggleware.Configitem as a struct containing a singleIdfield. Instead, it could be a non-struct type (component.ID). See the open questions section in README.md.Follows drafts
1: #12558
2: #12633
3: #12700
4: #12953
5: #13051
Link to tracking issue
Part of #7441
Part of #9591
Part of #12603
Part of #13228
Testing
N/A This will be broken into smaller PRs with tests.
Documentation
Documentation has been updated with new open questions.