Skip to content

Mdatagen: flatten the metric stability level#14424

Merged
dmitryax merged 9 commits into
open-telemetry:mainfrom
dmathieu:mdatagen-flatten-stability
Feb 10, 2026
Merged

Mdatagen: flatten the metric stability level#14424
dmitryax merged 9 commits into
open-telemetry:mainfrom
dmathieu:mdatagen-flatten-stability

Conversation

@dmathieu
Copy link
Copy Markdown
Member

This flattens the metrics stability level, to better match the weaver schema.
Closes #14113

@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.86%. Comparing base (8d9186a) to head (f551993).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #14424   +/-   ##
=======================================
  Coverage   91.86%   91.86%           
=======================================
  Files         677      677           
  Lines       42777    42759   -18     
=======================================
- Hits        39295    39281   -14     
+ Misses       2427     2424    -3     
+ Partials     1055     1054    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread processor/memorylimiterprocessor/metadata.yaml Outdated
@github-actions
Copy link
Copy Markdown
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions Bot added the Stale label Jan 29, 2026
@dmathieu dmathieu removed the Stale label Jan 29, 2026
@dmathieu dmathieu marked this pull request as ready for review February 5, 2026 14:42
@dmathieu dmathieu requested review from a team, bogdandrutu and dmitryax as code owners February 5, 2026 14:42
@dmathieu
Copy link
Copy Markdown
Member Author

dmathieu commented Feb 5, 2026

@dmitryax @ChrsMark This is ready for review.
Doing the contrib fixes, I have doubts if this isn't too much work for folks using mdatagen though (kinda like the components renames).
See the size of open-telemetry/opentelemetry-collector-contrib#45903

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Feb 5, 2026

CodSpeed Performance Report

Merging this PR will improve performance by 28.99%

Comparing dmathieu:mdatagen-flatten-stability (7288e7e) with main (42b573e)

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

Summary

⚡ 1 improved benchmark
✅ 60 untouched benchmarks
⏩ 20 skipped benchmarks1

Performance Changes

Benchmark BASE HEAD Efficiency
HTTP/1.1,_shared_client_(like_load_balancer) 1.4 ms 1.1 ms +28.99%

Footnotes

  1. 20 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Copy link
Copy Markdown
Member

@ChrsMark ChrsMark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall.

I agree the amount of changes is enormous but it's not quite user facing so I'd fine doing those to address the initial suggestion.

Comment thread cmd/mdatagen/internal/metric.go
Copy link
Copy Markdown
Member

@dmitryax dmitryax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmitryax dmitryax added this pull request to the merge queue Feb 10, 2026
Merged via the queue into open-telemetry:main with commit 9fe7713 Feb 10, 2026
48 of 50 checks passed
ChrsMark added a commit to open-telemetry/opentelemetry-collector-contrib that referenced this pull request Feb 12, 2026
This follows
open-telemetry/opentelemetry-collector#14424

---------

Co-authored-by: Christos Markou <chrismarkou92@gmail.com>
isaacaflores2 added a commit to elastic/opentelemetry-collector-components that referenced this pull request Feb 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[mdatagen] Consider updating metrics stability field to match Weaver

3 participants