Mdatagen: flatten the metric stability level#14424
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #14424 +/- ##
=======================================
Coverage 91.86% 91.86%
=======================================
Files 677 677
Lines 42777 42759 -18
=======================================
- Hits 39295 39281 -14
+ Misses 2427 2424 -3
+ Partials 1055 1054 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
@dmitryax @ChrsMark This is ready for review. |
CodSpeed Performance ReportMerging this PR will improve performance by 28.99%Comparing
|
| Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|
| ⚡ | HTTP/1.1,_shared_client_(like_load_balancer) |
1.4 ms | 1.1 ms | +28.99% |
Footnotes
-
20 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
ChrsMark
left a comment
There was a problem hiding this comment.
LGTM overall.
I agree the amount of changes is enormous but it's not quite user facing so I'd fine doing those to address the initial suggestion.
9fe7713
This follows open-telemetry/opentelemetry-collector#14424 --------- Co-authored-by: Christos Markou <chrismarkou92@gmail.com>
This is required due to the stability schema change in: open-telemetry/opentelemetry-collector#14424
This flattens the metrics stability level, to better match the weaver schema.
Closes #14113