Skip to content

Flatten stability attribute in metadata attributes#45903

Merged
ChrsMark merged 6 commits into
open-telemetry:stability-mdatagen-patchfrom
dmathieu:flatten-mdata-stability
Feb 12, 2026
Merged

Flatten stability attribute in metadata attributes#45903
ChrsMark merged 6 commits into
open-telemetry:stability-mdatagen-patchfrom
dmathieu:flatten-mdata-stability

Conversation

@dmathieu
Copy link
Copy Markdown
Member

@dmathieu dmathieu commented Feb 5, 2026

@dmathieu
Copy link
Copy Markdown
Member Author

For this to pass, the workflow that updates the collector to its latest commit needs to run.

@ChrsMark
Copy link
Copy Markdown
Member

ChrsMark commented Feb 11, 2026

For this to pass, the workflow that updates the collector to its latest commit needs to run.

This seems to run on Fridays:

- cron: "27 8 * * 5" # Run at 08:27 UTC on Fridays.

I'd be fine running this earlier to apply the fix immediately.

/cc @open-telemetry/collector-contrib-approvers

@mx-psi
Copy link
Copy Markdown
Member

mx-psi commented Feb 11, 2026

@dmathieu
Copy link
Copy Markdown
Member Author

Urgh it's a chicken and egg thing. The action can't run because this PR isn't merged, and this PR can't be merged until that action rans.

@dmathieu
Copy link
Copy Markdown
Member Author

And I can't run update-otel locally.

go: downloading github.com/DataDog/datadog-agent/comp/core/secrets/utils v0.76.0-rc.4
go: github.com/open-telemetry/opentelemetry-collector-contrib/cmd/otelcontribcol imports
github.com/open-telemetry/opentelemetry-collector-contrib/receiver/sqlqueryreceiver imports
github.com/open-telemetry/opentelemetry-collector-contrib/receiver/sqlqueryreceiver/internal imports
github.com/thda/tds: reading github.com/thda/tds/go.mod at revision v0.1.7: git ls-remote -q --end-of-options origin in /Users/dmathieu/code/pkg/mod/cache/vcs/6f48db50355a4a73f13ccbde907ca315a2ce0168bac09468bf640bf86ba169a9: exit status 128:
fatal: 'origin' does not appear to be a git repository
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.
go: github.com/open-telemetry/opentelemetry-collector-contrib/cmd/otelcontribcol imports
github.com/open-telemetry/opentelemetry-collector-contrib/receiver/snowflakereceiver imports
github.com/snowflakedb/gosnowflake imports
github.com/99designs/keyring imports
github.com/99designs/go-keychain: github.com/99designs/go-keychain@v0.0.0-20191008050251-8e49817e8af4: invalid version: git ls-remote -q --end-of-options origin in /Users/dmathieu/code/pkg/mod/cache/vcs/b7360a9bf0962ccbbbdde33d9b2afaa858108332182b20c493311b5829f1fd28: exit status 128:
fatal: 'origin' does not appear to be a git repository
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

make[1]: *** [genotelcontribcol] Error 1
make: *** [update-otel] Error 2

@ChrsMark
Copy link
Copy Markdown
Member

It seems to be a chicken and egg problem indeed and we cannot really migrate nicely since the stability field/key changes from object to string.

I guess we will need to break main for a while one way or the other.

@mx-psi would that be acceptable? Have we done something similar in the past?

@ChrsMark
Copy link
Copy Markdown
Member

ChrsMark commented Feb 12, 2026

I also wonder if we could just run the update-otel workflow from a branch that has these changes. i.e. merging dmathieu:flatten-mdata-stability to open-telemetry:stability-patch and run the workflow from the latter. Then we could merge open-telemetry:stability-patch to the branch of the created PR (the one that the workflow will create) so as to have both updates in one place before merging it to main.

@dmathieu
Copy link
Copy Markdown
Member Author

Changed the base branch of this PR so we can run the workflow in a branch that is not main.

@ChrsMark
Copy link
Copy Markdown
Member

@mx-psi
Copy link
Copy Markdown
Member

mx-psi commented Feb 12, 2026

It seems to be a chicken and egg problem indeed and we cannot really migrate nicely since the stability field/key changes from object to string.

I guess we will need to break main for a while one way or the other.

@mx-psi would that be acceptable? Have we done something similar in the past?

Sorry, missed this yesterday, I think the alternative you came up with sounds great

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

connector/grafanacloud connector/servicegraph exporter/elasticsearch exporter/kafka exporter/loadbalancing exporter/prometheusremotewrite exporter/sumologic internal/otelarrow internal/tools pkg/stanza/fileconsumer processor/deltatocumulative processor/filter Filter processor processor/groupbyattrs Group By Attributes processor processor/groupbytrace Group By Trace processor processor/k8sattributes k8s Attributes processor processor/logdedup processor/probabilisticsampler Probabilistic Sampler processor processor/tailsampling Tail sampling processor receiver/activedirectoryds receiver/aerospike receiver/apache receiver/apachespark receiver/bigip receiver/chrony receiver/ciscoos/internal/scraper/interfaces receiver/ciscoos/internal/scraper/systemscraper receiver/couchdb receiver/dockerstats receiver/elasticsearch receiver/expvar receiver/filestats receiver/flinkmetrics receiver/fluentforward receiver/github receiver/googlecloudpubsub receiver/googlecloudpubsubpush receiver/haproxy receiver/hostmetrics/internal/scraper/cpuscraper receiver/hostmetrics/internal/scraper/diskscraper receiver/hostmetrics/internal/scraper/filesystem receiver/hostmetrics/internal/scraper/loadscraper receiver/hostmetrics/internal/scraper/memory receiver/hostmetrics/internal/scraper/network receiver/hostmetrics/internal/scraper/nfsscraper receiver/hostmetrics/internal/scraper/paging receiver/hostmetrics/internal/scraper/process receiver/hostmetrics/internal/scraper/processes receiver/hostmetrics/internal/scraper/system receiver/httpcheck HTTP Check receiver receiver/icmpcheck receiver/iis receiver/k8scluster receiver/kafka receiver/kafkametrics receiver/kubeletstats receiver/memcached receiver/mongodb receiver/mongodbatlas receiver/mysql receiver/nginx receiver/nsxt NSXT Receiver receiver/ntp receiver/oracledb receiver/podman receiver/postgresql receiver/rabbitmq receiver/redfish receiver/redis Redis related issues receiver/riak receiver/saphana receiver/snowflake Snowflake receiver receiver/solace receiver/splunkenterprise receiver/sqlserver receiver/sshcheck receiver/statsd statsd related issues receiver/systemd receiver/tcpcheck receiver/tlscheck receiver/vcenter receiver/windowsservice receiver/yanggrpc Run Windows Enable running windows test on a PR scraper/zookeeper Skip Changelog PRs that do not require a CHANGELOG.md entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants