Skip to content

[exporterhelper] Move experimental symbols to xexporterhelper#13821

Merged
mx-psi merged 14 commits into
open-telemetry:mainfrom
mx-psi:mx-psi/move-exporterhelper-experimental-stuff
Sep 16, 2025
Merged

[exporterhelper] Move experimental symbols to xexporterhelper#13821
mx-psi merged 14 commits into
open-telemetry:mainfrom
mx-psi:mx-psi/move-exporterhelper-experimental-stuff

Conversation

@mx-psi
Copy link
Copy Markdown
Member

@mx-psi mx-psi commented Sep 10, 2025

Description

Moves all symbols marked as 'Experimental' to xexporterhelper.

Link to tracking issue

Updates #11143

@mx-psi mx-psi marked this pull request as ready for review September 10, 2025 11:45
@mx-psi mx-psi requested review from a team and dmathieu as code owners September 10, 2025 11:45
@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 10, 2025

Codecov Report

❌ Patch coverage is 75.93985% with 32 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.38%. Comparing base (2e9dda5) to head (f005db9).
⚠️ Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
exporter/exporterhelper/internal/new_request.go 79.31% 12 Missing and 6 partials ⚠️
...rter/exporterhelper/xexporterhelper/new_request.go 0.00% 8 Missing ⚠️
...r/exporterhelper/xexporterhelper/profiles_batch.go 40.00% 3 Missing ⚠️
exporter/exporterhelper/logs.go 87.50% 1 Missing ⚠️
exporter/exporterhelper/metrics.go 87.50% 1 Missing ⚠️
exporter/exporterhelper/traces.go 87.50% 1 Missing ⚠️

❌ Your patch status has failed because the patch coverage (75.93%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13821      +/-   ##
==========================================
- Coverage   91.42%   91.38%   -0.04%     
==========================================
  Files         646      648       +2     
  Lines       42606    42620      +14     
==========================================
- Hits        38952    38949       -3     
- Misses       2833     2849      +16     
- Partials      821      822       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mx-psi
Copy link
Copy Markdown
Member Author

mx-psi commented Sep 16, 2025

I will wait a couple more days before merging in case @dmitryax or @bogdandrutu want to review since they are the code owners of this part of the code

Copy link
Copy Markdown
Member

@dmitryax dmitryax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @mx-psi

@mx-psi mx-psi added this pull request to the merge queue Sep 16, 2025
Merged via the queue into open-telemetry:main with commit 6714771 Sep 16, 2025
56 of 57 checks passed
@mx-psi mx-psi deleted the mx-psi/move-exporterhelper-experimental-stuff branch September 16, 2025 18:08
@github-actions github-actions Bot added this to the next release milestone Sep 16, 2025
@mx-psi
Copy link
Copy Markdown
Member Author

mx-psi commented Sep 19, 2025

I forgot to move three symbols marked as experimental, I have moved them in #13868

github-merge-queue Bot pushed a commit that referenced this pull request Sep 22, 2025
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

<!-- Issue number if applicable -->

I forgot to move these symbols in #13821.

#### Link to tracking issue

Relates to open-telemetry/opentelemetry-collector-contrib/pull/42782,
which is how I noticed.

Follows #13821

Updates #11143
github-merge-queue Bot pushed a commit that referenced this pull request Sep 24, 2025
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

<!-- Issue number if applicable -->

Removes all deprecated symbols.

#### Link to tracking issue

Follows #13821
Follows #13868
Fixes #11143
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants