[exporterhelper] Deprecate RequestSizer#13804
Conversation
ee0efbf to
2b0646b
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #13804 +/- ##
==========================================
+ Coverage 91.43% 91.44% +0.01%
==========================================
Files 640 640
Lines 42665 42665
==========================================
+ Hits 39009 39017 +8
+ Misses 2836 2830 -6
+ Partials 820 818 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Please don't do this since they are planned to be used.
The whole idea is to allow other exporters to have different implementations of the Request object, and things like The RequestErroHandler type is used to communicate between the export function and the retry mechanism in case partial retries are needed.
I am OK if we want to drop the whole idea of supporting custom implementation for the Request then a larger cleanup is needed, otherwise we should let these helpers public so custom implementation can use.
|
@bogdandrutu I am going to do a bigger refactor and e.g. move the
I can just move |
|
I changed it so that we only remove |
|
#13821 moves all Experimental symbols to |
In QueueBatchSettings you can see there are some arguments like ItemsSizer which I think is the |
|
Okay, I see. I did not realize we were using type aliases in that way. I will then suggest we move this to xexporterhelper. Let's continue the discussion over at #13821 |
Description
Deprecates an unused type. As can be seen in https://github.com/search?q=%2FRequestSizer%5Cb%2F+-is%3Afork+language%3AGo+NOT+repo%3Arpradeepkumar7%2Ffirst-opentelemetry-exporter&type=code&l=Go it is not used anywhere, inside or outside of this repository
Link to tracking issue
Updates #11143