[chore]: enable fatcontext linter#13445
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13445 +/- ##
==========================================
- Coverage 91.44% 91.39% -0.06%
==========================================
Files 532 532
Lines 29537 29537
==========================================
- Hits 27010 26994 -16
- Misses 1997 2009 +12
- Partials 530 534 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mmorel-35
force-pushed
the
fatcontext
branch
4 times, most recently
from
7139f24 to
29ad3a1
Compare
|
|
||
| // test | ||
| err := enhanceStreamWithClientInformation(false)(nil, stream, nil, handler) | ||
| err := enhanceStreamWithClientInformation(false)(nil, stream, nil, handler(t)) |
There was a problem hiding this comment.
Should we ensure the handler is indeed executed?
There was a problem hiding this comment.
I ran it locally and the assertion in the handler is indeed executed.
Do you mean adding another assertion ?
There was a problem hiding this comment.
Yes, I mean a check within the test that fails if the handler isn't executed somehow.
mmorel-35
force-pushed
the
fatcontext
branch
2 times, most recently
from
6b494ef to
9faff6d
Compare
|
Can you fix the spellcheck? |
None of them are related to the modifications in this PR. |
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
51bff5f
3 participants
Description
Enable and fixes fatcontext linter