Skip to content

[chore]: fix cspell exclusion on .golangci.yml#13434

Merged
bogdandrutu merged 1 commit into
open-telemetry:mainfrom
mmorel-35:cspell-config
Jul 21, 2025
Merged

[chore]: fix cspell exclusion on .golangci.yml#13434
bogdandrutu merged 1 commit into
open-telemetry:mainfrom
mmorel-35:cspell-config

Conversation

@mmorel-35
Copy link
Copy Markdown
Contributor

@mmorel-35 mmorel-35 commented Jul 20, 2025

Description

fix cspell exclusion on .golangci.yml

Related to #13427

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@mmorel-35 mmorel-35 requested a review from a team as a code owner July 20, 2025 08:47
@mmorel-35 mmorel-35 requested a review from songy23 July 20, 2025 08:47
@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.47%. Comparing base (be09659) to head (e2c8634).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13434      +/-   ##
==========================================
- Coverage   91.48%   91.47%   -0.02%     
==========================================
  Files         529      529              
  Lines       29508    29508              
==========================================
- Hits        26996    26992       -4     
- Misses       1985     1988       +3     
- Partials      527      528       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Member

@dmathieu dmathieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦

@songy23 songy23 added ready-to-merge Code review completed; ready to merge by maintainers ci-cd CI, CD, testing, build issues labels Jul 21, 2025
@bogdandrutu bogdandrutu added this pull request to the merge queue Jul 21, 2025
Merged via the queue into open-telemetry:main with commit 352f70f Jul 21, 2025
81 of 83 checks passed
@mmorel-35 mmorel-35 deleted the cspell-config branch July 21, 2025 15:46
@jade-guiton-dd
Copy link
Copy Markdown
Contributor

jade-guiton-dd commented Jul 23, 2025

Hello 👋 Any idea why the cspell CI is still failing on this PR? From what I can tell it's up-to-date with main and includes this PR. cc @areebahmeddd

@areebahmeddd
Copy link
Copy Markdown
Contributor

areebahmeddd commented Jul 23, 2025

Yep my pr is upto latest sync with this commit included yet it fails 🤔 from what i debugged on my failing ci, i ignored the .golangci.yml at the workflow level [ my fix ]

this pattern in the workflow is including all .md,yaml,yml files in the repo

{36626446-C0F5-49ED-B2D7-FDC4C0BF1ADE}

an interesting thing, initially !.golanci.yml (a typo) existed in the workflow but was removed in this pr: 13427
cc @jade-guiton-dd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-cd CI, CD, testing, build issues ready-to-merge Code review completed; ready to merge by maintainers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants