[chore] convert configgrpc.KeepaliveServerConfig.ServerParameters and…#13364
Merged
mx-psi merged 3 commits intoJul 15, 2025
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13364 +/- ##
==========================================
- Coverage 91.53% 91.50% -0.03%
==========================================
Files 528 528
Lines 29469 29467 -2
==========================================
- Hits 26974 26964 -10
- Misses 1969 1975 +6
- Partials 526 528 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
once merged, will open a PR on contrib to fix references highlighted in failing contrib-tests |
jade-guiton-dd
approved these changes
Jul 9, 2025
Contributor
jade-guiton-dd
left a comment
jade-guiton-dd
left a comment
There was a problem hiding this comment.
Looks good to me, just a small nitpick
jade-guiton-dd
added
the
ready-to-merge
… EnforcementPolicy to configoptional
jackgopack4
force-pushed
the
jackgopack4/configgrpc-add-configoptional-keepaliveconfigs
branch
from
3f2d307 to
d0341ff
Compare
Merged
via the queue into
open-telemetry:main
with commit Jul 15, 2025
9551370
54 of 56 checks passed
mx-psi
deleted the
jackgopack4/configgrpc-add-configoptional-keepaliveconfigs
branch
mx-psi
pushed a commit
to open-telemetry/opentelemetry-collector-contrib
that referenced
this pull request
Jul 16, 2025
Signed-off-by: otelbot <197425009+otelbot@users.noreply.github.com><!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Convert tests/modules using `configgrpc.Keepalive` parameters to configoptional <!-- Issue number (e.g. #1234) or full URL to issue, if applicable. --> #### Link to tracking issue Required due to open-telemetry/opentelemetry-collector#13364 <!--Describe what testing was performed and which tests were added.--> #### Testing existing unit/e2e/integration tests <!--Describe the documentation added.--> #### Documentation none, no change to users or api in this repo <!--Please delete paragraphs that you did not use before submitting.-->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… EnforcementPolicy to configoptional
Description
converts
configgrpc.KeepaliveServerConfig.ServerParametersandconfiggrpc.KeepaliveServerConfig.EnforcementPolicyfrom pointers toconfigoptionaltypeLink to tracking issue
Fixes #13250 and follow-up to missed code in #13252
Testing
existing unit/ci tests
Documentation
update chloggen from #13252