[configgrpc] modify optional fields to use configoptional.Optional#13252
Merged
mx-psi merged 6 commits intoJul 8, 2025
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13252 +/- ##
==========================================
- Coverage 91.53% 91.50% -0.03%
==========================================
Files 526 526
Lines 29436 29436
==========================================
- Hits 26944 26936 -8
- Misses 1965 1971 +6
- Partials 527 529 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mx-psi
approved these changes
Jul 7, 2025
evan-bradley
approved these changes
Jul 7, 2025
Member
|
Needs |
Member
|
I think you just need |
Merged
via the queue into
open-telemetry:main
with commit Jul 8, 2025
74cb2f3
52 of 56 checks passed
This was referenced Jul 8, 2025
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Jul 15, 2025
#13364) … EnforcementPolicy to configoptional <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description converts `configgrpc.KeepaliveServerConfig.ServerParameters` and `configgrpc.KeepaliveServerConfig.EnforcementPolicy` from pointers to `configoptional` type <!-- Issue number if applicable --> #### Link to tracking issue Fixes #13250 and follow-up to missed code in #13252 <!--Describe what testing was performed and which tests were added.--> #### Testing existing unit/ci tests <!--Describe the documentation added.--> #### Documentation update chloggen from #13252 <!--Please delete paragraphs that you did not use before submitting.-->
sky333999
added a commit
to aws/amazon-cloudwatch-agent
that referenced
this pull request
Feb 12, 2026
otlpreceiver.Config.GRPC and .HTTP are now configoptional.Optional[T] initialized in the Default flavor by CreateDefaultConfig(). Default.Get() returns nil, so the previous code using .Get() silently skipped endpoint and TLS assignment. Replaced .Get() with .GetOrInsertDefault() which promotes Default → Some and returns a mutable pointer. Extracted TLS config into a shared variable that defaults to None (zero value) when no cert/key files are provided. Upstream PRs: - open-telemetry/opentelemetry-collector#13044 (configoptional module) - open-telemetry/opentelemetry-collector#13119 (otlpreceiver migration) - open-telemetry/opentelemetry-collector#13252 (configgrpc TLS migration)
sky333999
added a commit
to aws/amazon-cloudwatch-agent
that referenced
this pull request
Feb 15, 2026
otlpreceiver.Config.GRPC and .HTTP are now configoptional.Optional[T] initialized in the Default flavor by CreateDefaultConfig(). Default.Get() returns nil, so the previous code using .Get() silently skipped endpoint and TLS assignment. Replaced .Get() with .GetOrInsertDefault() which promotes Default → Some and returns a mutable pointer. Extracted TLS config into a shared variable that defaults to None (zero value) when no cert/key files are provided. Upstream PRs: - open-telemetry/opentelemetry-collector#13044 (configoptional module) - open-telemetry/opentelemetry-collector#13119 (otlpreceiver migration) - open-telemetry/opentelemetry-collector#13252 (configgrpc TLS migration)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
replace optional fields in
configgrpcwithconfigoptional.OptionalLink to tracking issue
Fixes #13250
Testing
updated existing tests
Documentation
Will add chloggen