Use Err prefix for always return error implementation#12874
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12874 +/- ##
=======================================
Coverage 91.47% 91.47%
=======================================
Files 494 494
Lines 26993 26994 +1
=======================================
+ Hits 24691 24692 +1
Misses 1818 1818
Partials 484 484 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jmacd
added a commit
to jmacd/opentelemetry-collector
that referenced
this pull request
Apr 16, 2025
jmacd
approved these changes
Apr 16, 2025
6d826b2 to
e7b1df4
Compare
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make this package consistent with a way more used package https://github.com/open-telemetry/opentelemetry-collector/blob/main/consumer/consumertest/err.go#L15