Middleware: config struct (part 2/4)#12844
Merged
bogdandrutu merged 20 commits intoApr 17, 2025
Merged
Conversation
bogdandrutu
reviewed
Apr 15, 2025
Member
bogdandrutu
left a comment
bogdandrutu
left a comment
There was a problem hiding this comment.
Need to add this in version.yaml.
…tor into jmacd/configmiddle_2_configmiddle
bogdandrutu
reviewed
Apr 15, 2025
Member
bogdandrutu
left a comment
bogdandrutu
left a comment
There was a problem hiding this comment.
LGTM, some comments about consistency and config
…tor into jmacd/configmiddle_2_configmiddle
…tor into jmacd/configmiddle_2_configmiddle
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12844 +/- ##
==========================================
+ Coverage 91.52% 91.54% +0.02%
==========================================
Files 494 499 +5
Lines 26983 27047 +64
==========================================
+ Hits 24695 24759 +64
Misses 1809 1809
Partials 479 479 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bogdandrutu
approved these changes
Apr 16, 2025
Co-authored-by: Bogdan Drutu <bogdandrutu@gmail.com>
…opentelemetry-collector into jmacd/configmiddle_2_configmiddle
bogdandrutu
approved these changes
Apr 17, 2025
Member
|
@jmacd please run |
github-merge-queue
Bot
removed this pull request from the merge queue due to a conflict with the base branch
…tor into jmacd/configmiddle_2_configmiddle
…tor into jmacd/configmiddle_2_configmiddle
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds the config struct from #12842.
Link to tracking issue
Part of #12603.
Testing
Yes. This PR introduces
extensionmiddlewaretesthelpers.Documentation
Added.