Skip to content

[mdatagen] Add Converter and Provider support#12467

Merged
dmitryax merged 3 commits into
open-telemetry:mainfrom
evan-bradley:add-confmap-to-mdatagen
Feb 26, 2025
Merged

[mdatagen] Add Converter and Provider support#12467
dmitryax merged 3 commits into
open-telemetry:mainfrom
evan-bradley:add-confmap-to-mdatagen

Conversation

@evan-bradley

@evan-bradley evan-bradley commented Feb 24, 2025

Copy link
Copy Markdown
Contributor

Description

Adds support for confmap Converters and Providers to mdatagen, which allows us to declare stability levels for these module types.

Helps unblock open-telemetry/opentelemetry-collector-releases#546.

@codecov

codecov Bot commented Feb 24, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.18%. Comparing base (2b5fa0e) to head (1e9117c).
Report is 12 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12467      +/-   ##
==========================================
- Coverage   92.19%   92.18%   -0.01%     
==========================================
  Files         465      465              
  Lines       25194    25171      -23     
==========================================
- Hits        23228    23205      -23     
  Misses       1570     1570              
  Partials      396      396              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bogdandrutu bogdandrutu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is special for them vs the generic "pkg"?

@evan-bradley

Copy link
Copy Markdown
Contributor Author

As a class of module: currently only the prefix (pkg/x vs. converter/x or provider/x) which are used in the labels in the generated readme. As a target for a certain level of stability: They're like extensions, so stability doesn't apply to a particular signal.

Considering the bulk of this change is just adding two new items to a few slices, I'm more inclined to explicitly add these as opposed to come up with exceptions for existing classes or make them work for more general cases. None of the existing options are really a great fit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants