Add the s3 provider to the contrib distro#546
Conversation
mx-psi
left a comment
mx-psi
left a comment
There was a problem hiding this comment.
I think we should add it to contrib's test build before adding it here
Agreed, I have this PR open to do that: open-telemetry/opentelemetry-collector-contrib#32916. Probably should have included that in the PR description, sorry. I'd like to have that merged before we merge this, but I would like to at least start the discussion of what prerequisites we'd like when including these in our distributions. |
|
I'll convert this to a draft while open-telemetry/opentelemetry-collector-contrib#32916 is in progress, and until we have consensus. |
|
Happy to review once we have open-telemetry/opentelemetry-collector-contrib#32916 merged. Excited for those changes! |
|
Please update the versions and we can get this in. |
|
Thanks for the reminder, I got diverted and lost track of this one; sorry for the lack of an update My plan before marking this as ready was to promote the provider to alpha, but in order to do that, mdatagen needs to support providers. We could look at accelerating the timeline there if you would like, otherwise I was going to pick that back up after I wrap up some other work. |
|
Has there been any movement on this? |
|
Hello, if there are any updates on this feature? |
|
@eduardoasantana @gordash2013 This continues to be blocked by #546 (comment). |
|
@evan-bradley can this be revisited yet? I see there are other providers (although not from contrib) in the manifests since b07bcb3 - despite mdatagen not supporting providers. Is there anything I can do to help get this out? |
|
@Jonnobrow Sorry for the long delay. open-telemetry/opentelemetry-collector#12467 is the first step to address this. |
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Adds support for confmap Converters and Providers to mdatagen, which allows us to declare stability levels for these module types. Helps unblock open-telemetry/opentelemetry-collector-releases#546.
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Officially promotes the s3 provider to alpha and records this with mdatagen. Requires #38226. Unblocks open-telemetry/opentelemetry-collector-releases#546. --------- Co-authored-by: Antoine Toulme <antoine@toulme.name>
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Officially promotes the s3 provider to alpha and records this with mdatagen. Requires open-telemetry#38226. Unblocks open-telemetry/opentelemetry-collector-releases#546. --------- Co-authored-by: Antoine Toulme <antoine@toulme.name>
7 participants
The s3 provider has not had any major changes for at least a year now, I think it should likely be safe to include it in the contrib distribution.
@Aneurysm9 as the codeowner, please block this if you think this component is not ready for wider use.