Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions .chloggen/codeboten_vcenter-fg.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
# Use this changelog template to create an entry for release notes.

# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
change_type: breaking

# The name of the component, or a single word describing the area of concern, (e.g. receiver/filelog)
component: receiver/vcenter

# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
note: Set resourcePoolMemoryUsageAttribute feature gate to beta.

# Mandatory: One or more tracking issues related to the change. You can use the PR number here if no issue exists.
issues: [47552]

# (Optional) One or more lines of additional information to render under the primary note.
# These lines will be padded with 2 spaces and then inserted directly into the document.
# Use pipe (|) for multiline entries.
subtext:

# If your change doesn't affect end users or the exported elements of any package,
# you should instead start your pull request title with [chore] or use the "Skip Changelog" label.
# Optional: The change log or logs in which this entry should be included.
# e.g. '[user]' or '[user, api]'
# Include 'user' if the change is relevant to end users.
# Include 'api' if there is a change to a library API.
# Default: '[user]'
change_logs: []
2 changes: 1 addition & 1 deletion receiver/vcenterreceiver/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ Details about the metrics produced by this receiver can be found in [metadata.ya

### Feature gates

**ALPHA**: `receiver.vcenter.resourcePoolMemoryUsageAttribute`
**BETA**: `receiver.vcenter.resourcePoolMemoryUsageAttribute`

The feature gate `receiver.vcenter.resourcePoolMemoryUsageAttribute` once enabled will enable the memory usage type attribute for
the `vcenter.resource_pool.memory.usage` metric.
Expand Down
2 changes: 1 addition & 1 deletion receiver/vcenterreceiver/documentation.md
Original file line number Diff line number Diff line change
Expand Up @@ -902,6 +902,6 @@ This component has the following feature gates:

| Feature Gate | Stage | Description | From Version | To Version | Reference |
| ------------ | ----- | ----------- | ------------ | ---------- | --------- |
| `receiver.vcenter.resourcePoolMemoryUsageAttribute` | alpha | Enables the memory usage type attribute for the vcenter.resource_pool.memory.usage metric | v0.104.0 | N/A | [Link](https://github.com/open-telemetry/opentelemetry-collector-contrib/pull/33741) |
| `receiver.vcenter.resourcePoolMemoryUsageAttribute` | beta | Enables the memory usage type attribute for the vcenter.resource_pool.memory.usage metric | v0.153.0 | N/A | [Link](https://github.com/open-telemetry/opentelemetry-collector-contrib/pull/33741) |

For more information about feature gates, see the [Feature Gates](https://github.com/open-telemetry/opentelemetry-collector/blob/main/featuregate/README.md) documentation.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions receiver/vcenterreceiver/metadata.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@ feature_gates:
- id: receiver.vcenter.resourcePoolMemoryUsageAttribute
description: >-
Enables the memory usage type attribute for the vcenter.resource_pool.memory.usage metric
stage: alpha
from_version: "v0.104.0"
stage: beta
from_version: "v0.153.0"
reference_url: https://github.com/open-telemetry/opentelemetry-collector-contrib/pull/33741
skip_strict_validation: true

Expand Down
4 changes: 3 additions & 1 deletion receiver/vcenterreceiver/scraper_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ import (

func TestScrape(t *testing.T) {
ctx := t.Context()
setResourcePoolMemoryUsageAttrFeatureGate(t, false)
mockServer := mock.MockServer(t, false)
defer mockServer.Close()

Expand All @@ -46,7 +47,6 @@ func TestScrapeConfigsEnabled(t *testing.T) {
optConfigs.Metrics.VcenterVMNetworkBroadcastPacketRate.Enabled = true
optConfigs.Metrics.VcenterVMNetworkMulticastPacketRate.Enabled = true
optConfigs.Metrics.VcenterVMCPUTime.Enabled = true
setResourcePoolMemoryUsageAttrFeatureGate(t, true)

cfg := &Config{
MetricsBuilderConfig: optConfigs,
Expand All @@ -63,6 +63,8 @@ func TestScrape_TLS(t *testing.T) {
mockServer := mock.MockServer(t, true)
defer mockServer.Close()

setResourcePoolMemoryUsageAttrFeatureGate(t, false)

cfg := &Config{
MetricsBuilderConfig: metadata.NewDefaultMetricsBuilderConfig(),
Endpoint: mockServer.URL,
Expand Down
Loading