Skip to content

[receiver/vcenter] set feature gate to beta#47552

Merged
codeboten merged 6 commits into
open-telemetry:mainfrom
codeboten:codeboten/vcenter-fg
Jun 3, 2026
Merged

[receiver/vcenter] set feature gate to beta#47552
codeboten merged 6 commits into
open-telemetry:mainfrom
codeboten:codeboten/vcenter-fg

Conversation

@codeboten

Copy link
Copy Markdown
Contributor

This was targetted to be enabled by default in v0.107.0... we are a few versions beyond that now.

Comment thread .chloggen/codeboten_vcenter-fg.yaml Outdated
@paulojmdias

Copy link
Copy Markdown
Member
        	            	 -  resource "map[vcenter.cluster.name:Cluster vcenter.datacenter.name:Datacenter vcenter.resource_pool.inventory_path:/Datacenter/host/Cluster/Resources vcenter.resource_pool.name:Resources]": scope "github.com/open-telemetry/opentelemetry-collector-contrib/receiver/vcenterreceiver": metric "vcenter.resource_pool.memory.usage": number of datapoints doesn't match expected: 1, actual: 3
        	            	 -  resource "map[vcenter.datacenter.name:Datacenter vcenter.host.name:esxi-111.europe-southeast1.gve.goog vcenter.resource_pool.inventory_path:/Datacenter/host/StandaloneHost/Resources vcenter.resource_pool.name:Resources]": scope "github.com/open-telemetry/opentelemetry-collector-contrib/receiver/vcenterreceiver": metric "vcenter.resource_pool.memory.usage": number of datapoints doesn't match expected: 1, actual: 3
        	Test:       	TestScrape

Test should also be updated 👍

@codeboten

Copy link
Copy Markdown
Contributor Author

Pinging code owners @schmikei @ishleenk17, please take a look

@github-actions

Copy link
Copy Markdown
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions Bot added the Stale label May 12, 2026

@andrzej-stencel andrzej-stencel left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, can you update the ToVersion?

Comment thread receiver/vcenterreceiver/metrics.go Outdated
@github-actions github-actions Bot removed the Stale label May 21, 2026

@schmikei schmikei left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codeboten apologies for the delay,

Seems like after #47558 this PR needs a rebase to work with mdatagen along with the stability bump for this effort.

Also apologies I was not involved in the original #33741 so that also appeared to have been missed. Once again apologies for the delayed review and thank you for noticing it!

codeboten added 5 commits May 29, 2026 08:07
This was targetted to be enabled by default in v0.107.0... we are a few versions beyond that now.

Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
@codeboten codeboten force-pushed the codeboten/vcenter-fg branch from c12c015 to 270b1c9 Compare May 29, 2026 15:27
@codeboten

Copy link
Copy Markdown
Contributor Author

Thanks @schmikei, please take a look i've updated the PR to update metadata and re-ran make generate

@codeboten codeboten merged commit 7aeb5e0 into open-telemetry:main Jun 3, 2026
183 of 185 checks passed
@codeboten codeboten deleted the codeboten/vcenter-fg branch June 3, 2026 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants