fix(receiver/prometheusremotewrite): count target_info samples in PRW response stats#47108
Merged
songy23 merged 4 commits intoMar 30, 2026
Conversation
… 2.0 response stats Signed-off-by: Naman-B-Parlecha <naman.parlecha@finalroundai.com>
Naman-B-Parlecha
requested review from
a team,
ArthurSens and
dashpole
as code owners
Contributor
|
Welcome, contributor! Thank you for your contribution to opentelemetry-collector-contrib. Important reminders:
A maintainer will review your pull request soon. Thank you for helping make OpenTelemetry better! |
github-actions
Bot
added
first-time contributor
dashpole
reviewed
Mar 23, 2026
dashpole
approved these changes
Mar 23, 2026
Co-authored-by: David Ashpole <dashpole@google.com>
ArthurSens
reviewed
Mar 30, 2026
Signed-off-by: Naman-B-Parlecha <namanparlecha@gmail.com>
Contributor
Author
|
@ArthurSens Done :) |
ArthurSens
added
the
ready to merge
songy23
reviewed
Mar 30, 2026
Co-authored-by: Yang Song <songy23@users.noreply.github.com>
Contributor
|
Thank you for your contribution @Naman-B-Parlecha! 🎉 We would like to hear from you about your experience contributing to OpenTelemetry by taking a few minutes to fill out this survey. If you are getting started contributing, you can also join the CNCF Slack channel #opentelemetry-new-contributors to ask for guidance and get help. |
This was referenced Apr 24, 2026
rashmichandrashekar
added a commit
to Azure/prometheus-collector
that referenced
this pull request
May 6, 2026
This PR upgrades the otelcollector to the latest version available for the opentelemetry-collector and opentelemetry-operator. It was automatically generated by the GitHub Actions workflow. The summary of the OSS changelog is below: # Prometheusreceiver Changes ## v0.148.0 to v0.150.0 Generated on: 2026-04-28 07:50:17 --- ### v0.149.0 - [**BREAKING**] `receiver/prometheus`: Remove the deprecated `report_extra_scrape_metrics` receiver configuration option and obsolete extra scrape metric feature gates. ([#44181](open-telemetry/opentelemetry-collector-contrib#44181)) `report_extra_scrape_metrics` is no longer accepted in `prometheusreceiver` configuration. Control extra scrape metrics through the PromConfig.ScrapeConfigs.ExtraScrapeMetrics setting instead. - [**FEATURE**] `receiver/prometheus`: Add support for reading instrumentation scope attributes from `otel_scope_<attribute-name>` labels while feature-gating deprecation of `otel_scope_info`. ([#41502](open-telemetry/opentelemetry-collector-contrib#41502)) Scope attributes are always extracted from `otel_scope_<attribute-name>` labels on metrics. The `receiver.prometheusreceiver.IgnoreScopeInfoMetric` feature gate (alpha, disabled by default) controls only whether the legacy `otel_scope_info` metric is ignored for scope attribute extraction. When the gate is disabled, both mechanisms coexist to support migration. See the specification change for motivation: open-telemetry/opentelemetry-specification#4505 - [**BUG FIX**] `receiver/prometheus_remote_write`: Count target_info samples in PRW response stats ([#47108](open-telemetry/opentelemetry-collector-contrib#47108)) ## Summary | Category | Count | |----------|-------| | Breaking Changes | 1 | | Features | 1 | | Bug Fixes | 1 | | Other Changes | 0 | | **Total** | **3** | # Target-allocator Changes ## v0.148.0 to v0.150.0 Generated on: 2026-04-28 07:50:39 --- ### 0.149.0 - [**BUG FIX**] `auto-instrumentation, opamp, target allocator`: Fix Env slice aliasing in Apache HTTPD, Nginx, OpAMP Bridge, and Target Allocator container builders when the spec slice has spare backing-array capacity ([#4954](open-telemetry/opentelemetry-operator#4954)) ## Summary | Category | Count | |----------|-------| | Breaking Changes | 0 | | Features | 0 | | Bug Fixes | 1 | | Other Changes | 0 | | **Total** | **1** | --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Grace Wehner <gracewehner@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: Rashmi Chandrashekar <rashmy@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is due to target_info not being counted in samples leading to miss match count as mentioned in the commet
Link to tracking issue
Fixes #45150
Testing
Added Sub-Test in TestTranslateV2 with
service with only target_info metricto verify stats are counted when target_infoservice with target_info metricpasses