Fix Env/VolumeMount slice aliasing in auto-instrumentation, OpAMP Bridge, and Target Allocator#4954
Merged
swiatekm merged 4 commits intoopen-telemetry:mainfrom Apr 13, 2026
Conversation
When a container's VolumeMounts slice has spare backing-array capacity (e.g. after processing by another webhook like Istio), append() reuses the backing array, causing later mutations to container.VolumeMounts to silently corrupt the clone init container's mounts. This results in: cp: target '/opt/opentelemetry-webserver/source-conf': No such file or directory Replace append with slices.Concat which always allocates a fresh slice.
Use slices.Clone when copying Spec.Env so the container's env-var slice does not share a backing array with the spec, preventing mutations from leaking across the boundary. Mirrors the same fix already applied to Apache HTTPD and Nginx injection (commit 1766c65).
ozzywalsh
changed the title
iblancasa
approved these changes
Apr 13, 2026
swiatekm
approved these changes
Apr 13, 2026
This was referenced Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
# Bug
The
apache_httpd&nginxinstrumentations were failing with errorcp: target '/opt/opentelemetry-webserver/source-conf': No such file or directoryReason being the clone-container's volumeMounts getting overwritten.
Summary
append()into a slice with spare backing-array capacity reuses the underlying array, causing later mutations to silently corrupt the original spec — or vice versa.VolumeMounts) usingslices.Concat; fixed in OpAMP Bridge and Target Allocator (Env) usingslices.Clone(same issue possible).Test plan