[receiver/prometheusremotewrite] Add remaining metric metadata translations as per spec#47006
Closed
singhvibhanshu wants to merge 4 commits into
Closed
[receiver/prometheusremotewrite] Add remaining metric metadata translations as per spec#47006singhvibhanshu wants to merge 4 commits into
singhvibhanshu wants to merge 4 commits into
Conversation
…ations as per spec
singhvibhanshu
requested review from
a team,
ArthurSens and
dashpole
as code owners
Signed-off-by: singhvibhanshu <singhvibhanshu@hotmail.com>
Member
Author
|
/rerun |
Contributor
|
I think we should probably skip this (@ArthurSens for a second opinion). We are removing this from the spec: open-telemetry/opentelemetry-specification#4954. The rationale is that prometheus exporters now largely allow metrics without suffixes, so it is easier to just not add suffixes on the pusher than strip them here. |
Contributor
|
Agree with @dashpole. |
Contributor
|
Really appreciate the effort you put in here. Sorry for the misdirection |
Member
Author
|
No worries @dashpole! I really enjoyed digging into the codebase and getting more familiar with the receiver's translation logic. Thanks for the heads-up on the spec change. |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #46984