Skip to content

[chore] Add depguard rule to prevent new semconv versions to be added #44606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mx-psi merged 4 commits into from
Dec 1, 2025
Merged

[chore] Add depguard rule to prevent new semconv versions to be added #44606

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
502d3ba
[chore] Add depguard rule to prevent new semconv versions to be added
mx-psi Nov 28, 2025
78b3366
Add semconv v1.36.0 to golangci config
mx-psi Nov 28, 2025
54cb25d
Merge branch 'main' into mx-psi/semconv-depguard-rule
mx-psi Nov 28, 2025
91a8db2
Apply suggestions from code review
mx-psi Nov 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 30 additions & 0 deletions .golangci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,36 @@ linters:

- pkg: sigs.k8s.io/yaml
desc: "Use 'go.yaml.in/yaml' instead of sigs.k8s.io/yaml"

semconv:
list-mode: lax
deny:
- pkg: go.opentelemetry.io/otel/semconv
desc: Use go.opentelemetry.io/otel/semconv/v1.38.0 instead. If a newer semconv version has been released, update the depguard rule.
allow:
# TODO: Remove older semconv versions after v1.37.0 migration is complete.

@codeboten codeboten Nov 28, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# TODO: Remove older semconv versions after v1.37.0 migration is complete.
# TODO: Remove older semconv versions after v1.38.0 migration is complete.

@atoulme atoulme Nov 29, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please see https://github.com/open-telemetry/semantic-conventions/issues/3149

# If for any reason an individual package needs to use an older semconv version,
# add a nolint directive on the import line.
- go.opentelemetry.io/otel/semconv/v1.6.1
- go.opentelemetry.io/otel/semconv/v1.8.0
- go.opentelemetry.io/otel/semconv/v1.9.0
- go.opentelemetry.io/otel/semconv/v1.12.0
- go.opentelemetry.io/otel/semconv/v1.13.0
- go.opentelemetry.io/otel/semconv/v1.15.0
- go.opentelemetry.io/otel/semconv/v1.16.0
- go.opentelemetry.io/otel/semconv/v1.18.0
- go.opentelemetry.io/otel/semconv/v1.21.0
- go.opentelemetry.io/otel/semconv/v1.22.0
- go.opentelemetry.io/otel/semconv/v1.25.0
- go.opentelemetry.io/otel/semconv/v1.26.0
- go.opentelemetry.io/otel/semconv/v1.27.0
- go.opentelemetry.io/otel/semconv/v1.28.0
- go.opentelemetry.io/otel/semconv/v1.30.0
- go.opentelemetry.io/otel/semconv/v1.32.0
- go.opentelemetry.io/otel/semconv/v1.34.0
- go.opentelemetry.io/otel/semconv/v1.36.0
- go.opentelemetry.io/otel/semconv/v1.37.0
Comment thread
mx-psi marked this conversation as resolved.
- go.opentelemetry.io/otel/semconv/v1.38.0

# Add a different guard rule so that we can ignore tests.
ignore-in-test:
Expand Down