Skip to content

[chore] Add depguard rule to prevent new semconv versions to be added#44606

Merged
mx-psi merged 4 commits into
open-telemetry:mainfrom
mx-psi:mx-psi/semconv-depguard-rule
Dec 1, 2025
Merged

[chore] Add depguard rule to prevent new semconv versions to be added#44606
mx-psi merged 4 commits into
open-telemetry:mainfrom
mx-psi:mx-psi/semconv-depguard-rule

Conversation

@mx-psi
Copy link
Copy Markdown
Member

@mx-psi mx-psi commented Nov 28, 2025

Description

Adds depguard rule that only allows the current semconv versions but excludes anything else.

Link to tracking issue

Updates #22095

@mx-psi mx-psi force-pushed the mx-psi/semconv-depguard-rule branch from 3a25c3c to 502d3ba Compare November 28, 2025 11:41
@mx-psi mx-psi marked this pull request as ready for review November 28, 2025 11:52
@mx-psi mx-psi requested a review from a team as a code owner November 28, 2025 11:52
@mx-psi mx-psi requested a review from bogdandrutu November 28, 2025 11:52
github-merge-queue Bot pushed a commit to open-telemetry/opentelemetry-collector that referenced this pull request Nov 28, 2025
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

Update semantic conventions to v1.37.0

Relates to open-telemetry/opentelemetry-collector-contrib/pull/44606
Comment thread .golangci.yml Outdated
Comment thread .golangci.yml
Co-authored-by: James Thompson <thompson.tomo@outlook.com>
Comment thread .golangci.yml
- pkg: go.opentelemetry.io/otel/semconv
desc: Use go.opentelemetry.io/otel/semconv/v1.38.0 instead. If a newer semconv version has been released, update the depguard rule.
allow:
# TODO: Remove older semconv versions after v1.37.0 migration is complete.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# TODO: Remove older semconv versions after v1.37.0 migration is complete.
# TODO: Remove older semconv versions after v1.38.0 migration is complete.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mx-psi mx-psi merged commit ef9cd61 into open-telemetry:main Dec 1, 2025
186 checks passed
@github-actions github-actions Bot added this to the next release milestone Dec 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants