[receiver/ciscoosreceiver] Implement interface scrapper#43815
Merged
Conversation
etserend
force-pushed
the
42647-add-system-scraper
branch
from
d588d01 to
d24b43a
Compare
etserend
force-pushed
the
42647-add-system-scraper
branch
2 times, most recently
from
2af63a5 to
0869485
Compare
dmitryax
reviewed
Oct 29, 2025
Member
dmitryax
left a comment
dmitryax
left a comment
There was a problem hiding this comment.
It looks like half of the code is logging. Is it really that useful?
etserend
force-pushed
the
42647-add-system-scraper
branch
3 times, most recently
from
08e35ad to
1f109cb
Compare
dmitryax
reviewed
Oct 30, 2025
etserend
force-pushed
the
42647-add-system-scraper
branch
from
c8009d2 to
cdbc057
Compare
etserend
force-pushed
the
42647-add-system-scraper
branch
from
8f75361 to
872e177
Compare
dmitryax
approved these changes
Oct 30, 2025
| return interfaces, nil | ||
| } | ||
|
|
||
| func (s *interfacesScraper) establishDeviceConnection(ctx context.Context) (*connection.RPCClient, error) { |
Member
There was a problem hiding this comment.
This function already exists. The connection can be created once for the whole receiver and passed down to the scrapers.
Feel free to improve it in a separate follow-up PR
Contributor
|
Thank you for your contribution @etserend! 🎉 We would like to hear from you about your experience contributing to OpenTelemetry by taking a few minutes to fill out this survey. If you are getting started contributing, you can also join the CNCF Slack channel #opentelemetry-new-contributors to ask for guidance and get help. |
jelly-afk
pushed a commit
to jelly-afk/opentelemetry-collector-contrib
that referenced
this pull request
Nov 6, 2025
…ry#43815) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Adds interface scraper to Cisco OS receiver with 9 network metrics following OpenTelemetry semantic conventions: <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue open-telemetry#42647 <!--Describe what testing was performed and which tests were added.--> #### Testing - Configuration validation and defaults - Factory creation and lifecycle tests - Interface parser (status, validation, formatting) - Fixed metric names to match OpenTelemetry conventions - Multi-device configuration tests - <!--Describe the documentation added.--> #### Documentation - Complete README with metric specifications and examples - All metrics defined in metadata.yaml - Generated documentation.md with attribute details <!--Please delete paragraphs that you did not use before submitting.-->
jelly-afk
pushed a commit
to jelly-afk/opentelemetry-collector-contrib
that referenced
this pull request
Nov 6, 2025
….0 (open-telemetry#44067) #### Description The same chlog entry was added in open-telemetry#43568 and open-telemetry#43815, resulting in duplicate entries in changelog and release notes. _I'll update release notes once this is merged._
dyl10s
pushed a commit
to dyl10s/opentelemetry-collector-contrib
that referenced
this pull request
Nov 21, 2025
…ry#43815) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Adds interface scraper to Cisco OS receiver with 9 network metrics following OpenTelemetry semantic conventions: <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue open-telemetry#42647 <!--Describe what testing was performed and which tests were added.--> #### Testing - Configuration validation and defaults - Factory creation and lifecycle tests - Interface parser (status, validation, formatting) - Fixed metric names to match OpenTelemetry conventions - Multi-device configuration tests - <!--Describe the documentation added.--> #### Documentation - Complete README with metric specifications and examples - All metrics defined in metadata.yaml - Generated documentation.md with attribute details <!--Please delete paragraphs that you did not use before submitting.-->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds interface scraper to Cisco OS receiver with 9 network metrics following OpenTelemetry semantic conventions:
Link to tracking issue
#42647
Testing
Documentation