[receiver/ciscoosreceiver] Add system scraper implementation#43568
Conversation
1e9b9e0 to
a5a14a6
Compare
271d76d to
87a7bd7
Compare
|
@etserend any particular reason why you are prefixing the system metrics with ciscoos when they resemble the generic system metrics just with less recommend attributes. Hence it should be possible to use the general metric to increase interoperability. |
87a7bd7 to
20cd57b
Compare
@thompson-tomo We're following semconv to avoid duplicating standard system metrics. CPU and memory metrics are aligned with the generic system ones. For device-specific metrics like cisco.device.up and cisco.collector.duration.seconds, keeping the cisco prefix might make sense since they don't map directly. |
2d26286 to
dd7e495
Compare
|
@etserend ahh, I had focussed on the documentation to determine whst metrics had been implemented rather than the code. Could you update the docs to match the code:
In relation to the up metric, feedback in open-telemetry/semantic-conventions#2939 is that an uptime metric is preferred otherwise a status metric could be offered with a running state. |
442583d to
3607772
Compare
4173aea to
b777bc7
Compare
6d24afe to
0936e4a
Compare
0936e4a to
41cffc9
Compare
41cffc9 to
3e6bb50
Compare
|
Thank you for your contribution @etserend! 🎉 We would like to hear from you about your experience contributing to OpenTelemetry by taking a few minutes to fill out this survey. If you are getting started contributing, you can also join the CNCF Slack channel #opentelemetry-new-contributors to ask for guidance and get help. |
….0 (open-telemetry#44067) #### Description The same chlog entry was added in open-telemetry#43568 and open-telemetry#43815, resulting in duplicate entries in changelog and release notes. _I'll update release notes once this is merged._
Description
Add system scraper implementation for the Cisco OS receiver to collect device availability and connection metrics from Cisco devices.
Link to tracking issue
#42647
Testing
Unit tests for system scraper config, factory, and scraping logic
Documentation