Skip to content

[chore][ci] improve Build gotestsum for Windows #43020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
atoulme merged 3 commits into from
Sep 28, 2025
Merged

[chore][ci] improve Build gotestsum for Windows #43020

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
64ef118
[chore][ci] improve Build gotestsum for Windows
paulojmdias Sep 26, 2025
167c92f
Merge branch 'main' into chore/ci_windows_gotestsum
atoulme Sep 27, 2025
b75fafe
Merge branch 'main' into chore/ci_windows_gotestsum
paulojmdias Sep 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 2 additions & 7 deletions .github/workflows/scoped-test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,14 +78,9 @@ jobs:
if: steps.go-setup.outputs.cache-hit != 'true'
run: make install-tools

- name: Build gotestsum on Windows
if: runner.os == 'Windows'
shell: pwsh # Explicitly set the shell to avoid actionlint treating this an attempt to escape single quote
run: make "$(${PWD} -replace '\\', '/')/.tools/gotestsum"

- name: Build gotestsum
if: runner.os != 'Windows'
run: make "$PWD/.tools/gotestsum"
working-directory: ${{ github.workspace }}
run: make .tools/gotestsum

@pjanotti pjanotti Sep 29, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The target needs to be the full path, as it is it breaks the step.

@pjanotti pjanotti Sep 29, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixing the target via #43036


- name: Run changed tests
if: needs.changedfiles.outputs.go_tests
Expand Down
Loading