[connector/spanmetrics] Use latest semantic conventions for status code attribute by Machyne · Pull Request #43000 · open-telemetry/opentelemetry-collector-contrib

Machyne · 2025-09-25T22:40:08Z

Description

Adds a feature gate to use the latest semantic conventions for the status code attribute on generated metrics. Changes:

Old Attribute	New Attribute
`status.code=STATUS_CODE_ERROR`	`otel.status_code=ERROR`
`status.code=STATUS_CODE_OK`	`otel.status_code=OK`
`status.code=STATUS_CODE_UNSET`	(no attribute)

Link to tracking issue

Partially Fixes #42103

Testing

Added new test case "Test using new status code attribute"

Documentation

README updated, changelog entry added

github-actions · 2025-09-25T22:40:23Z

Welcome, contributor! Thank you for your contribution to opentelemetry-collector-contrib.

Important reminders:

Please review our Contributing Guidelines.
Don't forget to sign the Contributor License Agreement (CLA) if you haven't already.

A maintainer will review your pull request soon. Thank you for helping make OpenTelemetry better!

Frapschen · 2025-09-26T01:09:20Z

+# Use this changelog template to create an entry for release notes.
+
+# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
+change_type: enhancement


I believe it's a breaking change

Frapschen · 2025-09-26T01:17:24Z

+component: spanmetricsconnector
+
+# A brief description of the change.  Surround your text with quotes ("") if it needs to start with a backtick (`).
+note: Add a feature gate to use the latest semantic conventions for the status code attribute on generated metrics.


nit: We can use subtext to explain the rationale behind introducing this breaking change, as well as how to use feature gates to roll it back.

In note we explicitly say that the key of span status change from status.code to otel.status_code

Frapschen · 2025-09-26T01:23:12Z

+	if useOtelStatusCodeAttribute.IsEnabled() {
+		if !contains(p.config.ExcludeDimensions, otelStatusCodeKey) {
+			if span.Status().Code() == ptrace.StatusCodeError {
+				attr.PutStr(otelStatusCodeKey, "ERROR")


This change also needs to be included in the changelog

Frapschen

LGTM with minor comments.

atoulme · 2025-09-28T07:08:13Z

Please address the changes and CI and mark ready for review again.

obs-gh-mattcotter · 2025-10-03T15:53:12Z

@iblancasa would you mind reviewing as well? It looks like github is requiring two maintainer approvals

Machyne · 2025-10-03T20:48:36Z

I think I misunderstood the issue; it seems like the workflows themselves need to be approved by a maintainer in order to run. @Frapschen would you be able to help with that? Or otherwise instruct on how to go about merging this if that isn't the blocker? Thank you!

Machyne · 2025-10-06T16:24:24Z

I'm not sure why the module check had failed. I rebased in hopes that it will solve the issue, but please let me know if it's otherwise actionable! I fixed the lint errors and the command the CI system had run: GOOS=linux GOARCH=amd64 make -j2 golint GROUP=connector now passes for me locally.

linux-foundation-easycla · 2025-10-06T19:27:16Z

The committers listed above are authorized under a signed CLA.

✅ login: Machyne / name: Matt Cotter (4fd36dc)

obs-gh-mattcotter · 2025-10-07T14:26:07Z

Rebasing broke my new unit test since service.name was removed from the resource attributes with the new feature gate. I updated the test and it works again.

Frapschen · 2025-10-09T03:02:43Z

@Machyne, I have tried to find an approver to approve the workflow to run.

Frapschen · 2025-10-09T03:05:35Z

@Machyne Please resolve the conflicts

Machyne · 2025-10-15T20:49:26Z

@Frapschen I rebased and pushed again!

Frapschen · 2025-10-16T02:29:58Z

@Machyne Changelog check fail

Machyne · 2025-10-16T14:02:33Z

@Frapschen sorry about that; the check must have been changed after I rebased. It's passing locally now.

Frapschen · 2025-10-17T07:31:15Z

 	"github.com/open-telemetry/opentelemetry-collector-contrib/pkg/pdatautil"
 )

+var useOtelStatusCodeAttribute = featuregate.GlobalRegistry().MustRegister(


@Machyne, can we move this to the factory.go?

@Frapschen I made this update. Sorry for the delay, I had missed your message. I believe the prior windows failure was unrelated to my change. I ran the test and lint locally after my recent rebase and I'm hoping we can get this merged!

…de attribute

github-actions · 2025-11-07T02:43:56Z

Welcome, contributor! Thank you for your contribution to opentelemetry-collector-contrib.

Important reminders:

Please review our Contributing Guidelines.
Don't forget to sign the Contributor License Agreement (CLA) if you haven't already.

A maintainer will review your pull request soon. Thank you for helping make OpenTelemetry better!

otelbot · 2025-11-19T21:34:44Z

Thank you for your contribution @Machyne! 🎉 We would like to hear from you about your experience contributing to OpenTelemetry by taking a few minutes to fill out this survey. If you are getting started contributing, you can also join the CNCF Slack channel #opentelemetry-new-contributors to ask for guidance and get help.

#### Description - Migrate programatically registered feature gates to `metadata.yaml`. Kept comments/TODO intact as I assumed they were committed for a reason in the first place. - `from_version` for each gate was determined via `git describe --contains <commit>` on the commit that introduced it: - `connector.spanmetrics.legacyMetricNames` → `v0.109.0` (#34485) - `connector.spanmetrics.includeCollectorInstanceID` → `v0.136.0` (#41865) - `connector.spanmetrics.useSecondAsDefaultMetricsUnit` → `v0.137.0` (#42761) - `connector.spanmetrics.excludeResourceMetrics` → `v0.137.0` (#42760) - `spanmetrics.statusCodeConvention.useOtelPrefix` → `v0.141.0` (#43000) - `spanmetrics.statusCodeConvention.useOtelPrefix` had no `reference_url` in the original registration, so I used the implementing PR as the reference URL as the issue was only partially fixed. - `connector_test.go` already imports `google.golang.org/grpc/metadata`, so the internal `metadata` package was imported with the alias `spanmetricsmetadata` to avoid a name conflict #### Link to tracking issue Part of #46116 #### Testing - `make` in the component directory - `make gogci` in root dir #### Documentation - `connector/spanmetricsconnector/documentation.md` was generated via `make generate`

…ry#48281) #### Description - Migrate programatically registered feature gates to `metadata.yaml`. Kept comments/TODO intact as I assumed they were committed for a reason in the first place. - `from_version` for each gate was determined via `git describe --contains <commit>` on the commit that introduced it: - `connector.spanmetrics.legacyMetricNames` → `v0.109.0` (open-telemetry#34485) - `connector.spanmetrics.includeCollectorInstanceID` → `v0.136.0` (open-telemetry#41865) - `connector.spanmetrics.useSecondAsDefaultMetricsUnit` → `v0.137.0` (open-telemetry#42761) - `connector.spanmetrics.excludeResourceMetrics` → `v0.137.0` (open-telemetry#42760) - `spanmetrics.statusCodeConvention.useOtelPrefix` → `v0.141.0` (open-telemetry#43000) - `spanmetrics.statusCodeConvention.useOtelPrefix` had no `reference_url` in the original registration, so I used the implementing PR as the reference URL as the issue was only partially fixed. - `connector_test.go` already imports `google.golang.org/grpc/metadata`, so the internal `metadata` package was imported with the alias `spanmetricsmetadata` to avoid a name conflict #### Link to tracking issue Part of open-telemetry#46116 #### Testing - `make` in the component directory - `make gogci` in root dir #### Documentation - `connector/spanmetricsconnector/documentation.md` was generated via `make generate`

Machyne requested a review from a team as a code owner September 25, 2025 22:40

Machyne requested a review from crobert-1 September 25, 2025 22:40

github-actions Bot assigned braydonk Sep 25, 2025

github-actions Bot added the first-time contributor PRs made by new contributors label Sep 25, 2025

github-actions Bot added the connector/spanmetrics label Sep 25, 2025

github-actions Bot requested review from Frapschen, iblancasa and portertech September 25, 2025 22:40

Machyne force-pushed the mc/spanmetrics branch from be23e17 to ad9ec76 Compare September 25, 2025 22:44

obs-gh-mattcotter mentioned this pull request Sep 25, 2025

[connector/spanmetrics] improvements to config and schema of output RED metrics #42103

Closed

Frapschen reviewed Sep 26, 2025

View reviewed changes

Frapschen approved these changes Sep 26, 2025

View reviewed changes

atoulme marked this pull request as draft September 28, 2025 07:08

Machyne force-pushed the mc/spanmetrics branch from ad9ec76 to 629b4b6 Compare September 29, 2025 20:51

Machyne marked this pull request as ready for review September 29, 2025 20:53

github-actions Bot assigned fatsheep9146 Sep 29, 2025

Frapschen approved these changes Sep 29, 2025

View reviewed changes

iblancasa approved these changes Oct 3, 2025

View reviewed changes

Machyne force-pushed the mc/spanmetrics branch from 629b4b6 to 50082dd Compare October 3, 2025 19:16

Machyne force-pushed the mc/spanmetrics branch 2 times, most recently from c0a8ab3 to 95dadeb Compare October 6, 2025 16:22

Machyne force-pushed the mc/spanmetrics branch from ab6d52b to 76ded24 Compare October 6, 2025 19:29

Machyne force-pushed the mc/spanmetrics branch from 76ded24 to 0fff84c Compare October 15, 2025 20:48

Machyne force-pushed the mc/spanmetrics branch from 0fff84c to 9f6f956 Compare October 16, 2025 13:58

Frapschen reviewed Oct 17, 2025

View reviewed changes

Machyne force-pushed the mc/spanmetrics branch from 9f6f956 to 2b6f797 Compare October 28, 2025 15:30

[connector/spanmetrics] Use latest semantic conventions for status co…

4fd36dc

…de attribute

Machyne force-pushed the mc/spanmetrics branch from 2b6f797 to 4fd36dc Compare October 28, 2025 15:33

Frapschen approved these changes Nov 7, 2025

View reviewed changes

Frapschen added the ready to merge Code review completed; ready to merge by maintainers label Nov 7, 2025

atoulme approved these changes Nov 19, 2025

View reviewed changes

atoulme merged commit a74bad7 into open-telemetry:main Nov 19, 2025
205 of 206 checks passed

github-actions Bot added this to the next release milestone Nov 19, 2025

kb-newrelic mentioned this pull request May 11, 2026

[chore][connector/spanmetrics]: migrate fgs to metadata #48281

Merged

Conversation

Machyne commented Sep 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Link to tracking issue

Testing

Documentation

Uh oh!

github-actions Bot commented Sep 25, 2025

Uh oh!

Frapschen Sep 26, 2025

Choose a reason for hiding this comment

Uh oh!

Frapschen Sep 26, 2025

Choose a reason for hiding this comment

Uh oh!

Frapschen Sep 26, 2025

Choose a reason for hiding this comment

Uh oh!

Frapschen left a comment

Choose a reason for hiding this comment

Uh oh!

atoulme commented Sep 28, 2025

Uh oh!

obs-gh-mattcotter commented Oct 3, 2025

Uh oh!

Machyne commented Oct 3, 2025

Uh oh!

Machyne commented Oct 6, 2025

Uh oh!

linux-foundation-easycla Bot commented Oct 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

obs-gh-mattcotter commented Oct 7, 2025

Uh oh!

Frapschen commented Oct 9, 2025

Uh oh!

Frapschen commented Oct 9, 2025

Uh oh!

Machyne commented Oct 15, 2025

Uh oh!

Frapschen commented Oct 16, 2025

Uh oh!

Machyne commented Oct 16, 2025

Uh oh!

Frapschen Oct 17, 2025

Choose a reason for hiding this comment

Uh oh!

Machyne Oct 28, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Nov 7, 2025

Uh oh!

Uh oh!

otelbot Bot commented Nov 19, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Machyne commented Sep 25, 2025 •

edited

Loading

linux-foundation-easycla Bot commented Oct 6, 2025 •

edited

Loading