[spanmetricsconnector]Change default duration metrics unit from ms to s#42761
Merged
Conversation
iblancasa
reviewed
Sep 19, 2025
atoulme
reviewed
Sep 22, 2025
Frapschen
force-pushed
the
fix-42462
branch
from
c1d6038 to
f53f700
Compare
iblancasa
approved these changes
Sep 22, 2025
TylerHelmuth
previously requested changes
Sep 25, 2025
Member
|
@Frapschen also please add a warning to the README that this change is coming. |
Co-authored-by: Antoine Toulme <antoine@toulme.name>
Frapschen
force-pushed
the
fix-42462
branch
from
b2c2dc4 to
2b03261
Compare
Co-authored-by: Tyler Helmuth <12352919+TylerHelmuth@users.noreply.github.com>
Co-authored-by: Tyler Helmuth <12352919+TylerHelmuth@users.noreply.github.com>
iblancasa
approved these changes
Sep 29, 2025
TylerHelmuth
approved these changes
Sep 29, 2025
TylerHelmuth
added
the
ready to merge
codeboten
pushed a commit
that referenced
this pull request
May 15, 2026
#### Description - Migrate programatically registered feature gates to `metadata.yaml`. Kept comments/TODO intact as I assumed they were committed for a reason in the first place. - `from_version` for each gate was determined via `git describe --contains <commit>` on the commit that introduced it: - `connector.spanmetrics.legacyMetricNames` → `v0.109.0` (#34485) - `connector.spanmetrics.includeCollectorInstanceID` → `v0.136.0` (#41865) - `connector.spanmetrics.useSecondAsDefaultMetricsUnit` → `v0.137.0` (#42761) - `connector.spanmetrics.excludeResourceMetrics` → `v0.137.0` (#42760) - `spanmetrics.statusCodeConvention.useOtelPrefix` → `v0.141.0` (#43000) - `spanmetrics.statusCodeConvention.useOtelPrefix` had no `reference_url` in the original registration, so I used the implementing PR as the reference URL as the issue was only partially fixed. - `connector_test.go` already imports `google.golang.org/grpc/metadata`, so the internal `metadata` package was imported with the alias `spanmetricsmetadata` to avoid a name conflict #### Link to tracking issue Part of #46116 #### Testing - `make` in the component directory - `make gogci` in root dir #### Documentation - `connector/spanmetricsconnector/documentation.md` was generated via `make generate`
ben-trans
pushed a commit
to ben-trans/opentelemetry-collector-contrib
that referenced
this pull request
May 25, 2026
…ry#48281) #### Description - Migrate programatically registered feature gates to `metadata.yaml`. Kept comments/TODO intact as I assumed they were committed for a reason in the first place. - `from_version` for each gate was determined via `git describe --contains <commit>` on the commit that introduced it: - `connector.spanmetrics.legacyMetricNames` → `v0.109.0` (open-telemetry#34485) - `connector.spanmetrics.includeCollectorInstanceID` → `v0.136.0` (open-telemetry#41865) - `connector.spanmetrics.useSecondAsDefaultMetricsUnit` → `v0.137.0` (open-telemetry#42761) - `connector.spanmetrics.excludeResourceMetrics` → `v0.137.0` (open-telemetry#42760) - `spanmetrics.statusCodeConvention.useOtelPrefix` → `v0.141.0` (open-telemetry#43000) - `spanmetrics.statusCodeConvention.useOtelPrefix` had no `reference_url` in the original registration, so I used the implementing PR as the reference URL as the issue was only partially fixed. - `connector_test.go` already imports `google.golang.org/grpc/metadata`, so the internal `metadata` package was imported with the alias `spanmetricsmetadata` to avoid a name conflict #### Link to tracking issue Part of open-telemetry#46116 #### Testing - `make` in the component directory - `make gogci` in root dir #### Documentation - `connector/spanmetricsconnector/documentation.md` was generated via `make generate`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Following OTel conventions, the default histogram unit is changed from
mstos.This is a breaking change, but with the changelog guide, user can easily and quickly change the unit to their desired unit.
Link to tracking issue
Fixes #42462