-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[extension/ackextension] release ackextension in alpha stability #32308
Merged
dmitryax
merged 49 commits into
open-telemetry:main
from
zpzhuSplunk:release-ack-extension
Apr 16, 2024
Merged
Changes from all commits
Commits
Show all changes
49 commits
Select commit
Hold shift + click to select a range
3c24fd7
[extension/ackextension] release ackextension in alpha stability
zpzhuSplunk ac1043d
add chloggen
zpzhuSplunk ea41899
test
zpzhuSplunk f932bcb
test
zpzhuSplunk a9b13bc
test
zpzhuSplunk ba569d5
Merge branch 'main' into release-ack-extension
zpzhuSplunk 9f58d54
test
zpzhuSplunk 0d19233
Merge branch 'main' into release-ack-extension
zpzhuSplunk f8038c9
test
zpzhuSplunk 78ef6ea
test
zpzhuSplunk 94a6bf6
address MR comments
zpzhuSplunk 3160c6e
Merge branch 'main' into release-ack-extension
zpzhuSplunk 6e14555
test
zpzhuSplunk a8440e0
test
zpzhuSplunk a975188
test
zpzhuSplunk 29b2f72
Merge branch 'main' into release-ack-extension
zpzhuSplunk 12e900c
test
zpzhuSplunk b2b98cb
test
zpzhuSplunk 304272f
test
zpzhuSplunk bbe55f6
Merge branch 'main' into release-ack-extension
zpzhuSplunk 0dc5d11
test
zpzhuSplunk bdac36a
Merge branch 'main' into release-ack-extension
zpzhuSplunk 1baea33
test'
zpzhuSplunk e300158
test
zpzhuSplunk be3e849
test
zpzhuSplunk 667077d
test
zpzhuSplunk 0f3103e
test
zpzhuSplunk c19a803
test
zpzhuSplunk a8f8817
Merge branch 'main' into release-ack-extension
zpzhuSplunk 1692539
Merge branch 'main' into release-ack-extension
zpzhuSplunk b6ee825
test
zpzhuSplunk c89a434
test
zpzhuSplunk 74bfba0
Merge branch 'main' into release-ack-extension
zpzhuSplunk e077e77
Merge branch 'main' into release-ack-extension
zpzhuSplunk 18082d8
Merge branch 'main' into release-ack-extension
zpzhuSplunk b31cfaa
address PR comments
zpzhuSplunk a86f99c
test
zpzhuSplunk 285b70b
test
zpzhuSplunk a5a1fe0
add extension
zpzhuSplunk 907f708
test
zpzhuSplunk f8bd589
test
zpzhuSplunk 3962053
Merge branch 'main' into release-ack-extension
zpzhuSplunk d970415
test
zpzhuSplunk 27a5b9d
test
zpzhuSplunk d7cbc9a
Merge branch 'main' into release-ack-extension
zpzhuSplunk 8d2acde
Merge branch 'main' into release-ack-extension
zpzhuSplunk b0b135f
Merge branch 'main' into release-ack-extension
zpzhuSplunk 49277d0
test
zpzhuSplunk 9cfc9e8
Merge branch 'main' into release-ack-extension
zpzhuSplunk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
# Use this changelog template to create an entry for release notes. | ||
|
||
# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix' | ||
change_type: new_component | ||
|
||
# The name of the component, or a single word describing the area of concern, (e.g. filelogreceiver) | ||
component: ackextension | ||
|
||
# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`). | ||
note: "Promote to `alpha` stability" | ||
|
||
# Mandatory: One or more tracking issues related to the change. You can use the PR number here if no issue exists. | ||
issues: [26376] | ||
|
||
# (Optional) One or more lines of additional information to render under the primary note. | ||
# These lines will be padded with 2 spaces and then inserted directly into the document. | ||
# Use pipe (|) for multiline entries. | ||
subtext: | ||
|
||
# If your change doesn't affect end users or the exported elements of any package, | ||
# you should instead start your pull request title with [chore] or use the "Skip Changelog" label. | ||
# Optional: The change log or logs in which this entry should be included. | ||
# e.g. '[user]' or '[user, api]' | ||
# Include 'user' if the change is relevant to end users. | ||
# Include 'api' if there is a change to a library API. | ||
# Default: '[user]' | ||
change_logs: [user] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe you also want to add the component to the extensions block near the top of this file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok I added the component.
make checks
seemed to have resolved my component to version v0.0.0-00010101000000-000000000000. I assume this is normal given that the extension hasn't been released yet. Is this the right version to use?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it matters either way as the replace will simply override whatever is stated with the current contents of the relative dir below. However, could you test to see if CI passes with
v0.98.0
? (Same with otherv0.0...
reference incmd/otelcontribcol/go.mod
)