Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[extension/ackextension] release ackextension in alpha stability #32308

Merged
merged 49 commits into from
Apr 16, 2024

Conversation

zpzhuSplunk
Copy link
Contributor

@zpzhuSplunk zpzhuSplunk commented Apr 10, 2024

Description:
release ackextension in alpha stability so other components can start using it.

Link to tracking Issue:
#26376

Testing:

Documentation:

@zpzhuSplunk zpzhuSplunk force-pushed the release-ack-extension branch from 462212e to 3c24fd7 Compare April 10, 2024 22:37
@zpzhuSplunk zpzhuSplunk force-pushed the release-ack-extension branch from d1b0d7c to f932bcb Compare April 10, 2024 23:01
Copy link
Member

@crobert-1 crobert-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v0.98.0 was just released, so version numbers here should be updated to match 👍

cmd/otelcontribcol/builder-config.yaml Outdated Show resolved Hide resolved
cmd/oteltestbedcol/builder-config.yaml Outdated Show resolved Hide resolved
extension/ackextension/README.md Outdated Show resolved Hide resolved
.chloggen/release-ack-extension.yaml Outdated Show resolved Hide resolved
.chloggen/release-ack-extension.yaml Outdated Show resolved Hide resolved
.chloggen/release-ack-extension.yaml Outdated Show resolved Hide resolved
@zpzhuSplunk zpzhuSplunk force-pushed the release-ack-extension branch from d88f164 to 3160c6e Compare April 11, 2024 22:42
@crobert-1
Copy link
Member

My apologies, you're right, it's not clear. It's being generated from here, so you'd actually want to update the builder config. I believe you'll also want to add the extension to the extension tests here as well.

@zpzhuSplunk zpzhuSplunk force-pushed the release-ack-extension branch from 398f935 to a86f99c Compare April 15, 2024 21:53
@zpzhuSplunk zpzhuSplunk force-pushed the release-ack-extension branch from 33c79a4 to 285b70b Compare April 15, 2024 22:07
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe you also want to add the component to the extensions block near the top of this file.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok I added the component. make checks seemed to have resolved my component to version v0.0.0-00010101000000-000000000000. I assume this is normal given that the extension hasn't been released yet. Is this the right version to use?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it matters either way as the replace will simply override whatever is stated with the current contents of the relative dir below. However, could you test to see if CI passes with v0.98.0? (Same with other v0.0... reference in cmd/otelcontribcol/go.mod)

@zpzhuSplunk
Copy link
Contributor Author

Hi @dmitryax, minding taking a look?

@zpzhuSplunk zpzhuSplunk force-pushed the release-ack-extension branch from beadcfd to a5a1fe0 Compare April 15, 2024 23:04
@zpzhuSplunk zpzhuSplunk force-pushed the release-ack-extension branch from f48483a to 907f708 Compare April 15, 2024 23:15
@zpzhuSplunk zpzhuSplunk requested a review from crobert-1 April 16, 2024 18:41
@@ -20,6 +20,8 @@ import (
"go.opentelemetry.io/collector/extension/extensiontest"
"go.opentelemetry.io/collector/extension/zpagesextension"

"github.com/open-telemetry/opentelemetry-collector-contrib/extension/ackextension"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it matters either way as the replace will simply override whatever is stated with the current contents of the relative dir below. However, could you test to see if CI passes with v0.98.0? (Same with other v0.0... reference in cmd/otelcontribcol/go.mod)

@zpzhuSplunk zpzhuSplunk force-pushed the release-ack-extension branch from 65e421a to f8bd589 Compare April 16, 2024 19:01
Copy link
Contributor

@atoulme atoulme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmitryax dmitryax merged commit 8a1737f into open-telemetry:main Apr 16, 2024
156 checks passed
@github-actions github-actions bot added this to the next release milestone Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants