Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rego: pass inter-query builtin cache to wasm sdk #3721

Conversation

srenatus
Copy link
Contributor

@srenatus srenatus commented Aug 9, 2021

Found when looking into open-policy-agent/opa-envoy-plugin#650.

With this change, multiple calls to a wasm-backed eval that uses http.send
would re-use the results (if caching permits).

Found when looking into #3716.

With this change, multiple calls to a wasm-backed eval that uses http.send
would re-use the results (if caching permits).

Signed-off-by: Stephan Renatus <[email protected]>
Copy link
Member

@ashutosh-narkar ashutosh-narkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@srenatus srenatus merged commit 47d1cb6 into open-policy-agent:main Aug 9, 2021
@srenatus srenatus deleted the sr/rego->wasm/pass-inter-query-builtin-cache-to-vm branch August 9, 2021 17:43
jgchn pushed a commit to jgchn/opa that referenced this pull request Aug 20, 2021
)

Found when looking into #3716.

With this change, multiple calls to a wasm-backed eval that uses http.send
would re-use the results (if caching permits).

Signed-off-by: Stephan Renatus <[email protected]>
dolevf pushed a commit to dolevf/opa that referenced this pull request Nov 4, 2021
)

Found when looking into #3716.

With this change, multiple calls to a wasm-backed eval that uses http.send
would re-use the results (if caching permits).

Signed-off-by: Stephan Renatus <[email protected]>
Signed-off-by: Dolev Farhi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants